From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
anthony.l.nguyen@intel.com, kuba@kernel.org, bjorn@kernel.org,
magnus.karlsson@intel.com, jesse.brandeburg@intel.com,
alexandr.lobakin@intel.com, joamaki@gmail.com, toke@redhat.com,
brett.creeley@intel.com,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [PATCH v7 intel-next 1/9] ice: remove ring_active from ice_ring
Date: Thu, 19 Aug 2021 13:59:56 +0200 [thread overview]
Message-ID: <20210819120004.34392-2-maciej.fijalkowski@intel.com> (raw)
In-Reply-To: <20210819120004.34392-1-maciej.fijalkowski@intel.com>
This field is dead and driver is not making any use of it. Simply remove
it.
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 --
drivers/net/ethernet/intel/ice/ice_main.c | 1 -
drivers/net/ethernet/intel/ice/ice_txrx.h | 2 --
3 files changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 327b39d7cd71..860e41966b71 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -1338,7 +1338,6 @@ static int ice_vsi_alloc_rings(struct ice_vsi *vsi)
ring->q_index = i;
ring->reg_idx = vsi->txq_map[i];
- ring->ring_active = false;
ring->vsi = vsi;
ring->tx_tstamps = &pf->ptp.port.tx;
ring->dev = dev;
@@ -1357,7 +1356,6 @@ static int ice_vsi_alloc_rings(struct ice_vsi *vsi)
ring->q_index = i;
ring->reg_idx = vsi->rxq_map[i];
- ring->ring_active = false;
ring->vsi = vsi;
ring->netdev = vsi->netdev;
ring->dev = dev;
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 802a59345bfa..1fa9c3cdf087 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -2441,7 +2441,6 @@ static int ice_xdp_alloc_setup_rings(struct ice_vsi *vsi)
xdp_ring->q_index = xdp_q_idx;
xdp_ring->reg_idx = vsi->txq_map[xdp_q_idx];
- xdp_ring->ring_active = false;
xdp_ring->vsi = vsi;
xdp_ring->netdev = NULL;
xdp_ring->dev = dev;
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.h b/drivers/net/ethernet/intel/ice/ice_txrx.h
index b0bbbec4e3a3..901f16f1d286 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.h
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.h
@@ -275,8 +275,6 @@ struct ice_ring {
u16 q_index; /* Queue number of ring */
u16 q_handle; /* Queue handle per TC */
- u8 ring_active:1; /* is ring online or not */
-
u16 count; /* Number of descriptors */
u16 reg_idx; /* HW register index of the ring */
--
2.20.1
next prev parent reply other threads:[~2021-08-19 12:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 11:59 [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Maciej Fijalkowski
2021-08-19 11:59 ` Maciej Fijalkowski [this message]
2021-09-13 6:47 ` [Intel-wired-lan] [PATCH v7 intel-next 1/9] ice: remove ring_active from ice_ring G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 2/9] ice: move ice_container_type onto ice_ring_container Maciej Fijalkowski
2021-09-13 6:50 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 3/9] ice: split ice_ring onto Tx/Rx separate structs Maciej Fijalkowski
2021-09-22 18:28 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 4/9] ice: unify xdp_rings accesses Maciej Fijalkowski
2021-09-03 6:37 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 5/9] ice: do not create xdp_frame on XDP_TX Maciej Fijalkowski
2021-09-03 6:40 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 6/9] ice: propagate xdp_ring onto rx_ring Maciej Fijalkowski
2021-09-03 6:45 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 7/9] ice: optimize XDP_TX workloads Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 8/9] ice: introduce XDP_TX fallback path Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 9/9] ice: make use of ice_for_each_* macros Maciej Fijalkowski
2021-09-22 18:26 ` [Intel-wired-lan] " G, GurucharanX
2021-08-25 7:57 ` [Intel-wired-lan] [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819120004.34392-2-maciej.fijalkowski@intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brett.creeley@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joamaki@gmail.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).