From: Daniel Xu <dxu@dxuuu.xyz>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix build of task_pt_regs tests for arm64
Date: Thu, 2 Sep 2021 11:32:20 -0700 [thread overview]
Message-ID: <20210902183220.eu5ddkgnlakr7yw2@kashmir.localdomain> (raw)
In-Reply-To: <20210902090925.2010528-1-jean-philippe@linaro.org>
On Thu, Sep 02, 2021 at 11:09:26AM +0200, Jean-Philippe Brucker wrote:
> struct pt_regs is not exported to userspace on all archs. arm64 and s390
> export "user_pt_regs" instead, which causes build failure at the moment:
>
> progs/test_task_pt_regs.c:8:16: error: variable has incomplete type 'struct pt_regs'
> struct pt_regs current_regs = {};
>
> Use the multi-arch macros defined by tools/lib/bpf/bpf_tracing.h to copy
> the pt_regs into a locally-defined struct.
>
> Copying the user_pt_regs struct on arm64 wouldn't work because the
> struct is too large and the compiler complains about using too much
> stack.
>
> Fixes: 576d47bb1a92 ("bpf: selftests: Add bpf_task_pt_regs() selftest")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> .../selftests/bpf/bpf_pt_regs_helpers.h | 30 +++++++++++++++++++
> .../selftests/bpf/prog_tests/task_pt_regs.c | 1 +
> .../selftests/bpf/progs/test_task_pt_regs.c | 10 ++++---
> 3 files changed, 37 insertions(+), 4 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/bpf_pt_regs_helpers.h
Acked-by: Daniel Xu <dxu@dxuuu.xyz>
[...]
next prev parent reply other threads:[~2021-09-02 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:09 [PATCH bpf-next] selftests/bpf: Fix build of task_pt_regs tests for arm64 Jean-Philippe Brucker
2021-09-02 18:32 ` Daniel Xu [this message]
2021-09-02 19:13 ` Alexei Starovoitov
2021-09-03 12:33 ` Jean-Philippe Brucker
2021-09-03 16:51 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902183220.eu5ddkgnlakr7yw2@kashmir.localdomain \
--to=dxu@dxuuu.xyz \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jean-philippe@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).