From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
To: <kuba@kernel.org>
Cc: <Rao.Shoaib@oracle.com>, <andrii@kernel.org>, <ast@kernel.org>,
<cong.wang@bytedance.com>, <daniel@iogearbox.net>,
<davem@davemloft.net>, <edumazet@google.com>,
<jbi.octave@gmail.com>, <jiang.wang@bytedance.com>,
<john.fastabend@gmail.com>, <kafai@fb.com>, <kpsingh@kernel.org>,
<kuniyu@amazon.co.jp>, <songliubraving@fb.com>,
<viro@zeniv.linux.org.uk>, <yhs@fb.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop()
Date: Sat, 2 Oct 2021 18:43:17 +0900 [thread overview]
Message-ID: <20211002094317.8623-1-kuniyu@amazon.co.jp> (raw)
In-Reply-To: <20211001180439.55bdc79f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Fri, 1 Oct 2021 18:04:39 -0700
From: Jakub Kicinski <kuba@kernel.org>
> On Sat, 2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
> > Sparse reports a warning at bpf_iter_unix_seq_stop()
> > The root cause is a missing annotation at bpf_iter_unix_seq_stop()
> >
> > Add the missing __releases(unix_table_lock) annotation
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
I completely missed that...
Thanks!
> > ---
> > net/unix/af_unix.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> > index efac5989edb5..9838d4d855e0 100644
> > --- a/net/unix/af_unix.c
> > +++ b/net/unix/af_unix.c
> > @@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
> > }
> >
> > static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
> > + __releases(unix_table_lock)
> > {
> > struct bpf_iter_meta meta;
> > struct bpf_prog *prog;
>
> You need to CC bpf@vger... and netdev@vger...
>
> You can drop the CC for linux-kernel@, approximately nobody reads that.
Added bpf and netdev, and dropped linux-kernel.
Thank you.
parent reply other threads:[~2021-10-02 9:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20211001180439.55bdc79f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211002094317.8623-1-kuniyu@amazon.co.jp \
--to=kuniyu@amazon.co.jp \
--cc=Rao.Shoaib@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jbi.octave@gmail.com \
--cc=jiang.wang@bytedance.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).