From: "Michal Koutný" <mkoutny@suse.com>
To: Quanyang Wang <quanyang.wang@windriver.com>
Cc: Roman Gushchin <guro@fb.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] cgroup: fix memory leak caused by missing cgroup_bpf_offline
Date: Tue, 12 Oct 2021 11:32:55 +0200 [thread overview]
Message-ID: <20211012093255.GA14510@blackbody.suse.cz> (raw)
In-Reply-To: <6d76de0b-9de7-adbe-834b-c49ed991559d@windriver.com>
On Tue, Oct 12, 2021 at 02:22:13PM +0800, Quanyang Wang <quanyang.wang@windriver.com> wrote:
> Before this commit, percpu_ref is embedded in cgroup, it can be freed along
> with cgroup, so there is no memory leak. Since this commit, it causes the
> memory leak.
> Should I change it to "Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of
> cgroup_bpf from cgroup itself")"?
I see. The leak is a product so I'd tag both of them and explain it in
the commit message.
Thank you,
Michal
prev parent reply other threads:[~2021-10-12 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:16 [PATCH] cgroup: fix memory leak caused by missing cgroup_bpf_offline quanyang.wang
2021-10-11 16:21 ` Michal Koutný
2021-10-11 16:29 ` Roman Gushchin
2021-10-22 15:50 ` John Fastabend
2021-10-12 6:22 ` Quanyang Wang
2021-10-12 9:32 ` Michal Koutný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012093255.GA14510@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=quanyang.wang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).