From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
bpf@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [RFC 7/9] bpf: split get_id and fd_by_id in bpf_attr
Date: Wed, 20 Oct 2021 10:15:42 -0700 [thread overview]
Message-ID: <20211020171542.7vn3lsrqmq2h7q2v@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211014143436.54470-10-lmb@cloudflare.com>
On Thu, Oct 14, 2021 at 03:34:33PM +0100, Lorenz Bauer wrote:
> ---
> include/uapi/linux/bpf.h | 60 ++++++++++++++++++++++++++++++++--------
> kernel/bpf/syscall.c | 18 ++++++------
> 2 files changed, 58 insertions(+), 20 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index d3acd12d98c1..13d126c201ce 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1422,17 +1422,43 @@ union bpf_attr {
> __u32 cpu;
> } test;
>
> - struct { /* anonymous struct used by BPF_*_GET_*_ID */
> - union {
> - __u32 start_id;
> - __u32 prog_id;
> - __u32 map_id;
> - __u32 btf_id;
> - __u32 link_id;
> - };
> - __u32 next_id;
> - __u32 open_flags;
> - };
> + struct { /* used by BPF_PROG_GET_FD_BY_ID command */
> + __u32 id;
> + } prog_get_fd_by_id;
> +
> + struct { /* used by BPF_MAP_GET_FD_BY_ID command */
> + __u32 id;
> + __u32 ingnored;
> + __u32 open_flags;
> + } map_get_fd_by_id;
> +
> + struct { /* used by BPF_BTF_GET_FD_BY_ID command */
> + __u32 id;
> + } btf_get_fd_by_id;
> +
> + struct { /* used by BPF_LINK_GET_FD_BY_ID command */
> + __u32 id;
> + } link_get_fd_by_id;
> +
> + struct { /* used by BPF_PROG_GET_NEXT_ID command */
> + __u32 start_id;
> + __u32 next_id;
> + } prog_get_next_id;
> +
> + struct { /* used by BPF_MAP_GET_NEXT_ID command */
> + __u32 start_id;
> + __u32 next_id;
> + } map_get_next_id;
> +
> + struct { /* used by BPF_BTF_GET_NEXT_ID command */
> + __u32 start_id;
> + __u32 next_id;
> + } btf_get_next_id;
> +
> + struct { /* used by BPF_LINK_GET_NEXT_ID command */
> + __u32 start_id;
> + __u32 next_id;
> + } link_get_next_id;
This one looks like churn though.
next prev parent reply other threads:[~2021-10-20 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 14:34 [RFC 0/9] uapi/bpf.h for robots Lorenz Bauer
2021-10-14 14:34 ` [RFC 1/9] bpf: name enums used from userspace Lorenz Bauer
2021-10-14 14:34 ` [RFC 2/9] bpf: various constants Lorenz Bauer
2021-10-14 14:43 ` Greg KH
2021-10-14 14:47 ` Lorenz Bauer
2021-10-14 14:56 ` Greg KH
2021-10-14 14:34 ` [RFC 3/9] bpf: move up __bpf_md_ptr Lorenz Bauer
2021-10-14 14:34 ` [RFC 4/9] bpf: name __u64 member of __bpf_md_ptr Lorenz Bauer
2021-10-14 14:34 ` [RFC 5/9] bpf: enum bpf_map_create_attr Lorenz Bauer
2021-10-14 14:34 ` [RFC 5/9] bpf: introduce CHECK_ATTR_TAIL Lorenz Bauer
2021-10-14 14:34 ` [RFC 6/9] bpf: split map modification structs Lorenz Bauer
2021-10-20 17:13 ` Alexei Starovoitov
2021-10-14 14:34 ` [RFC 6/9] bpf: struct bpf_map_create_attr Lorenz Bauer
2021-10-14 14:34 ` [RFC 7/9] bpf: split get_id and fd_by_id in bpf_attr Lorenz Bauer
2021-10-20 17:15 ` Alexei Starovoitov [this message]
2021-10-21 15:59 ` Lorenz Bauer
2021-10-27 18:20 ` Alexei Starovoitov
2021-10-29 14:01 ` Lorenz Bauer
2021-10-14 14:34 ` [RFC 7/9] bpf: split map modification structs Lorenz Bauer
2021-10-14 14:34 ` [RFC 8/9] selftests: sync bpf.h Lorenz Bauer
2021-10-14 14:34 ` [RFC 9/9] libbpf: use new-style syscall args Lorenz Bauer
2021-10-20 17:19 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020171542.7vn3lsrqmq2h7q2v@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=lmb@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).