bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Bixuan Cui <cuibixuan@linux.alibaba.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, leon@kernel.org, w@1wt.eu,
	keescook@chromium.org, bpf@vger.kernel.org,
	netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jakub Kicinski <kuba@kernel.org>,
	kvm@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls
Date: Wed, 1 Dec 2021 20:29:05 -0800	[thread overview]
Message-ID: <20211201202905.b9892171e3f5b9a60f9da251@linux-foundation.org> (raw)
In-Reply-To: <10cb0382-012b-5012-b664-c29461ce4de8@linux.alibaba.com>

On Thu, 2 Dec 2021 12:05:15 +0800 Bixuan Cui <cuibixuan@linux.alibaba.com> wrote:

> 
> 在 2021/12/2 上午11:26, Andrew Morton 写道:
> >> Delete the WARN_ON() and return NULL directly for oversized parameter
> >> in kvmalloc() calls.
> >> Also add unlikely().
> >>
> >> Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls")
> >> Signed-off-by: Bixuan Cui<cuibixuan@linux.alibaba.com>
> >> ---
> >> There are a lot of oversize warnings and patches about kvmalloc() calls
> >> recently. Maybe these warnings are not very necessary.
> > Or maybe they are.  Please let's take a look at these warnings, one at
> > a time.  If a large number of them are bogus then sure, let's disable
> > the runtime test.  But perhaps it's the case that calling code has
> > genuine issues and should be repaired.
> Such as：

Thanks, that's helpful.

Let's bring all these to the attention of the relevant developers.

If the consensus is "the code's fine, the warning is bogus" then let's
consider retiring the warning.

If the consensus is otherwise then hopefully they will fix their stuff!



> https://syzkaller.appspot.com/bug?id=24452f89446639c901ac07379ccc702808471e8e

(cc bpf@vger.kernel.org)

> https://syzkaller.appspot.com/bug?id=f7c5a86e747f9b7ce333e7295875cd4ede2c7a0d

(cc netdev@vger.kernel.org, maintainers)

> https://syzkaller.appspot.com/bug?id=8f306f3db150657a1f6bbe1927467084531602c7

(cc kvm@vger.kernel.org)

> https://syzkaller.appspot.com/bug?id=6f30adb592d476978777a1125d1f680edfc23e00

(cc netfilter-devel@vger.kernel.org)

> https://syzkaller.appspot.com/bug?id=4c9ab8c7d0f8b551950db06559dc9cde4119ac83

(bpf again).


       reply	other threads:[~2021-12-02  4:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1638410784-48646-1-git-send-email-cuibixuan@linux.alibaba.com>
     [not found] ` <20211201192643.ecb0586e0d53bf8454c93669@linux-foundation.org>
     [not found]   ` <10cb0382-012b-5012-b664-c29461ce4de8@linux.alibaba.com>
2021-12-02  4:29     ` Andrew Morton [this message]
2021-12-02 10:38       ` [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls Jeremy Sowden
2021-12-02 15:34         ` Alexei Starovoitov
2021-12-02 21:16           ` Jeremy Sowden
2021-12-02 11:49       ` Bixuan Cui
2021-12-03 19:37       ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211201202905.b9892171e3f5b9a60f9da251@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cuibixuan@linux.alibaba.com \
    --cc=daniel@iogearbox.net \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).