From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, bpf@vger.kernel.org,
Kiran Bhandare <kiranx.bhandare@intel.com>
Subject: [PATCH net 3/6] ice: remove dead store on XSK hotpath
Date: Fri, 17 Dec 2021 11:31:11 -0800 [thread overview]
Message-ID: <20211217193114.392106-4-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20211217193114.392106-1-anthony.l.nguyen@intel.com>
From: Alexander Lobakin <alexandr.lobakin@intel.com>
The 'if (ntu == rx_ring->count)' block in ice_alloc_rx_buffers_zc()
was previously residing in the loop, but after introducing the
batched interface it is used only to wrap-around the NTU descriptor,
thus no more need to assign 'xdp'.
Fixes: db804cfc21e9 ("ice: Use the xsk batched rx allocation interface")
Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/ice/ice_xsk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
index c124229d98fe..27f5f64dcbd6 100644
--- a/drivers/net/ethernet/intel/ice/ice_xsk.c
+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
@@ -397,7 +397,6 @@ bool ice_alloc_rx_bufs_zc(struct ice_rx_ring *rx_ring, u16 count)
ntu += nb_buffs;
if (ntu == rx_ring->count) {
rx_desc = ICE_RX_DESC(rx_ring, 0);
- xdp = rx_ring->xdp_buf;
ntu = 0;
}
--
2.31.1
next prev parent reply other threads:[~2021-12-17 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 19:31 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2021-12-17 Tony Nguyen
2021-12-17 19:31 ` [PATCH net 1/6] ice: xsk: return xsk buffers back to pool when cleaning the ring Tony Nguyen
2021-12-17 19:31 ` [PATCH net 2/6] ice: xsk: allocate separate memory for XDP SW ring Tony Nguyen
2021-12-17 19:31 ` Tony Nguyen [this message]
2021-12-17 19:31 ` [PATCH net 4/6] ice: xsk: do not clear status_error0 for ntu + nb_buffs descriptor Tony Nguyen
2021-12-17 19:31 ` [PATCH net 5/6] ice: xsk: allow empty Rx descriptors on XSK ZC data path Tony Nguyen
2021-12-17 19:31 ` [PATCH net 6/6] ice: xsk: fix cleaned_count setting Tony Nguyen
2021-12-18 12:30 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2021-12-17 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217193114.392106-4-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kiranx.bhandare@intel.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).