From: Kenny Yu <kennyyu@fb.com>
To: <alexei.starovoitov@gmail.com>
Cc: <andrii@kernel.org>, <ast@kernel.org>, <bpf@vger.kernel.org>,
<daniel@iogearbox.net>, <kennyyu@fb.com>, <phoenix1987@gmail.com>,
<yhs@fb.com>
Subject: Re: [PATCH v3 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper
Date: Wed, 19 Jan 2022 14:51:10 -0800 [thread overview]
Message-ID: <20220119225110.2026595-1-kennyyu@fb.com> (raw)
In-Reply-To: <CAADnVQKDfacNQD8WCp-mmQeyWd6Y09_b41L1=E3b3A6+GCyH+w@mail.gmail.com>
> > +BPF_CALL_5(bpf_access_process_vm, void *, dst, u32, size,
> > + const void __user *, user_ptr, struct task_struct *, tsk,
> > + u32, flags)
> > +{
> > + /* flags is not used yet */
> > + return access_process_vm(tsk, (unsigned long)user_ptr, dst, size, 0);
> > +}
>
> Though the 'flags' argument is unused the helper has to check
> that it's zero and return -EINVAL otherwise.
> If we don't do this we won't be able to change the behavior later
> due to backward compatibility.
Thanks for the feedback! Will fix.
Kenny
next prev parent reply other threads:[~2022-01-19 22:51 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 23:31 [PATCH bpf-next 0/3] Add bpf_access_process_vm helper and sleepable bpf iterator programs Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 0/4] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 1/4] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 2/4] bpf: Add support for sleepable programs in bpf_iter_run_prog Kenny Yu
2022-01-14 2:50 ` Alexei Starovoitov
2022-01-14 23:15 ` Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 3/4] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-14 0:49 ` [PATCH v2 bpf-next 4/4] selftests/bpf: Add test " Kenny Yu
2022-01-14 2:39 ` Alexei Starovoitov
2022-01-14 23:14 ` Kenny Yu
2022-01-15 1:38 ` Andrii Nakryiko
2022-01-15 4:30 ` Kenny Yu
2022-01-15 16:27 ` Gabriele
2022-01-19 16:56 ` Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-19 20:16 ` Alexei Starovoitov
2022-01-19 22:51 ` Kenny Yu [this message]
2022-01-19 18:02 ` [PATCH v3 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-20 3:45 ` Yonghong Song
2022-01-20 17:11 ` Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-20 22:45 ` Andrii Nakryiko
2022-01-21 2:27 ` Alexei Starovoitov
2022-01-21 17:20 ` Andrii Nakryiko
2022-01-21 17:41 ` Kenny Yu
2022-01-21 17:47 ` Alexei Starovoitov
2022-01-21 18:30 ` Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-20 22:48 ` Andrii Nakryiko
2022-01-21 19:30 ` [PATCH v6 bpf-next 0/3] Add bpf_copy_from_user_task helper and " Kenny Yu
2022-01-21 19:30 ` [PATCH v6 bpf-next 1/3] bpf: Add bpf_copy_from_user_task() helper Kenny Yu
2022-01-21 19:53 ` Andrii Nakryiko
2022-01-21 20:04 ` Yonghong Song
2022-01-21 20:07 ` Andrii Nakryiko
2022-01-21 21:15 ` Yonghong Song
2022-01-24 17:30 ` Kenny Yu
2022-01-22 9:58 ` Gabriele
2022-01-22 10:08 ` Gabriele
2022-01-21 19:30 ` [PATCH v6 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-21 19:54 ` Andrii Nakryiko
2022-01-21 19:30 ` [PATCH v6 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-21 19:55 ` Andrii Nakryiko
2022-01-24 18:53 ` [PATCH v7 bpf-next 0/4] Add bpf_copy_from_user_task helper and " Kenny Yu
2022-01-24 18:54 ` [PATCH v7 bpf-next 1/4] bpf: Add support for bpf iterator programs to use sleepable helpers Kenny Yu
2022-01-24 22:19 ` Andrii Nakryiko
2022-01-24 18:54 ` [PATCH v7 bpf-next 2/4] bpf: Add bpf_copy_from_user_task() helper Kenny Yu
2022-01-24 22:18 ` Andrii Nakryiko
2022-01-25 4:06 ` Alexei Starovoitov
2022-01-24 18:54 ` [PATCH v7 bpf-next 3/4] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-24 18:54 ` [PATCH v7 bpf-next 4/4] selftests/bpf: Add test " Kenny Yu
2022-01-25 4:10 ` [PATCH v7 bpf-next 0/4] Add bpf_copy_from_user_task helper and " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119225110.2026595-1-kennyyu@fb.com \
--to=kennyyu@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=phoenix1987@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).