bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hou Tao <houtao1@huawei.com>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andrii@kernel.org>,
	Zi Shen Lim <zlim.lnx@gmail.com>, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>, <bpf@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <houtao1@huawei.com>
Subject: [PATCH bpf-next v3 0/2] bpf, arm64: fix bpf line info
Date: Tue, 8 Feb 2022 09:25:37 +0800	[thread overview]
Message-ID: <20220208012539.491753-1-houtao1@huawei.com> (raw)

Hi,

The patchset addresses two issues in bpf line info for arm64:

(1) insn_to_jit_off only considers the body itself and ignores
    prologue before the body. Fixed in patch #1.

(2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is
    calculated in instruction granularity instead of bytes
    granularity. Fixed in patch #2.

Comments are always welcome.

Regards,
Tao

Change Log:
v3:
 * patch #2: explain why bpf2a64_offset() needs update
 * add Fixes tags in both patches

v2: https://lore.kernel.org/bpf/20220125105707.292449-1-houtao1@huawei.com
 * split into two independent patches (from Daniel)
 * use AARCH64_INSN_SIZE instead of defining INSN_SIZE

v1: https://lore.kernel.org/bpf/20220104014236.1512639-1-houtao1@huawei.com

Hou Tao (2):
  bpf, arm64: call build_prologue() first in first JIT pass
  bpf, arm64: calculate offset as byte-offset for bpf line info

 arch/arm64/net/bpf_jit_comp.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

-- 
2.27.0


             reply	other threads:[~2022-02-08  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08  1:25 Hou Tao [this message]
2022-02-08  1:25 ` [PATCH bpf-next v3 1/2] bpf, arm64: call build_prologue() first in first JIT pass Hou Tao
2022-02-08  1:25 ` [PATCH bpf-next v3 2/2] bpf, arm64: calculate offset as byte-offset for bpf line info Hou Tao
2022-02-18 23:20   ` Daniel Borkmann
2022-02-22  3:58     ` Hou Tao
2022-02-16 11:10 ` [PATCH bpf-next v3 0/2] bpf, arm64: fix " Hou Tao
2022-02-16 18:29 ` Martin KaFai Lau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208012539.491753-1-houtao1@huawei.com \
    --to=houtao1@huawei.com \
    --cc=andrii@kernel.org \
    --cc=ard.biesheuvel@arm.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel@iogearbox.net \
    --cc=kafai@fb.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    --cc=yhs@fb.com \
    --cc=zlim.lnx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).