From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Alexander Egorenkov <Alexander.Egorenkov@ibm.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
brouer@redhat.com, daniel@iogearbox.net, fw@strlen.de,
john.fastabend@gmail.com, kafai@fb.com, maximmi@nvidia.com,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pablo@netfilter.org, songliubraving@fb.com, toke@redhat.com,
yhs@fb.com, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH bpf-next v8 00/10] Introduce unstable CT lookup helpers
Date: Sat, 19 Feb 2022 03:50:17 +0530 [thread overview]
Message-ID: <20220218222017.czshdolesamkqv4j@apollo.legion> (raw)
In-Reply-To: <87y228q66f.fsf@oc8242746057.ibm.com>
On Sat, Feb 19, 2022 at 01:49:04AM IST, Alexander Egorenkov wrote:
>
> Hi,
>
> we are having a problem loading nf_conntrack on linux-next:
>
> # modprobe nf_conntrack
> modprobe: ERROR: could not insert 'nf_conntrack': Unknown symbol in module, or unknown parameter (see dmesg)
> modprobe: ERROR: Error running install command '/sbin/modprobe --ignore-install nf_conntrack && /sbin/sysctl --quiet --pattern 'net[.]netfilter[.]nf_conntrack.*' --system' for module nf_conntrack: retcode 1
> modprobe: ERROR: could not insert 'nf_conntrack': Invalid argument
>
> # dmesg
> [ 3728.188969] missing module BTF, cannot register kfuncs
> [ 3748.208674] missing module BTF, cannot register kfuncs
> [ 3748.567123] missing module BTF, cannot register kfuncs
> [ 3873.597276] missing module BTF, cannot register kfuncs
> [ 3874.017125] missing module BTF, cannot register kfuncs
> [ 3882.637097] missing module BTF, cannot register kfuncs
> [ 3883.507213] missing module BTF, cannot register kfuncs
> [ 3883.876878] missing module BTF, cannot register kfuncs
>
> # zgrep BTF /proc/config.gz
> CONFIG_DEBUG_INFO_BTF=y
> CONFIG_PAHOLE_HAS_SPLIT_BTF=y
> CONFIG_DEBUG_INFO_BTF_MODULES=y
>
> It seems that nf_conntrack.ko is missing a .BTF section
> which is present in debuginfo within
> /usr/lib/debug/lib/modules/*/kernel/net/netfilter/nf_conntrack.ko.debug instead.
>
> Am i correct in assuming that this is not supported (yet) ?
>
> We use pahole 1.22 and build linux-next on Fedora 35 as a set of custom
> packages. Architecture is s390x.
>
+Cc Ilya
Thanks for the report, Alex.
My assumption was that if DEBUG_INFO_BTF options was enabled, and BTF was not
present, it is a problem, but it seems it can happen even when the options are
enabled.
I guess if .BTF section isn't supported/emitted on s390x, we have to relax the
error and print a warning and ignore it, but I am not sure. Ilya would probably
know the current status.
We have already relaxed it once in (bpf-next):
c446fdacb10d ("bpf: fix register_btf_kfunc_id_set for !CONFIG_DEBUG_INFO_BTF")
If this doesn't work on s390x, we should probably just print a warning when
CONFIG_DEBUG_INFO_BTF is enabled and btf == NULL, and return 0.
> Thanks
> Regards
> Alex
>
--
Kartikeya
next prev parent reply other threads:[~2022-02-18 22:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 16:39 [PATCH bpf-next v8 00/10] Introduce unstable CT lookup helpers Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 01/10] bpf: Fix UAF due to race between btf_try_get_module and load_module Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 02/10] bpf: Populate kfunc BTF ID sets in struct btf Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 03/10] bpf: Remove check_kfunc_call callback and old kfunc BTF ID API Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 04/10] bpf: Introduce mem, size argument pair support for kfunc Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 05/10] bpf: Add reference tracking support to kfunc Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 06/10] net/netfilter: Add unstable CT lookup helpers for XDP and TC-BPF Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 07/10] selftests/bpf: Add test for unstable CT lookup API Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 08/10] selftests/bpf: Add test_verifier support to fixup kfunc call insns Kumar Kartikeya Dwivedi
2022-01-14 16:39 ` [PATCH bpf-next v8 09/10] selftests/bpf: Extend kfunc selftests Kumar Kartikeya Dwivedi
2022-05-26 1:22 ` Benjamin Poirier
2022-05-26 5:15 ` Kumar Kartikeya Dwivedi
2022-05-26 6:19 ` Benjamin Poirier
2022-01-14 16:39 ` [PATCH bpf-next v8 10/10] selftests/bpf: Add test for race in btf_try_get_module Kumar Kartikeya Dwivedi
2022-01-18 22:52 ` Alexei Starovoitov
2022-02-18 20:19 ` [PATCH bpf-next v8 00/10] Introduce unstable CT lookup helpers Alexander Egorenkov
2022-02-18 22:20 ` Kumar Kartikeya Dwivedi [this message]
2022-02-19 7:39 ` Alexander Egorenkov
2022-02-19 8:20 ` Kumar Kartikeya Dwivedi
2022-02-20 1:13 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218222017.czshdolesamkqv4j@apollo.legion \
--to=memxor@gmail.com \
--cc=Alexander.Egorenkov@ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=fw@strlen.de \
--cc=iii@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).