From: Martin KaFai Lau <kafai@fb.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix warning comparing pointer to 0
Date: Thu, 24 Mar 2022 13:28:48 -0700 [thread overview]
Message-ID: <20220324202848.2ncrqbzv3dv5qifo@kafai-mbp> (raw)
In-Reply-To: <1648087725-29435-1-git-send-email-baihaowen@meizu.com>
On Thu, Mar 24, 2022 at 10:08:45AM +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
Which compiler version that warns ?
I don't see it with the latest llvm-project from github.
The patch lgtm.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2022-03-24 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 2:08 [PATCH] selftests/bpf: Fix warning comparing pointer to 0 Haowen Bai
2022-03-24 20:28 ` Martin KaFai Lau [this message]
2022-03-25 1:15 ` 答复: " 白浩文
2022-03-25 19:55 ` Shuah Khan
2022-03-30 1:59 ` [PATCH V2] " Haowen Bai
2022-03-30 3:16 ` Yonghong Song
2022-03-30 13:30 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 10:00 [PATCH] selftests/bpf: fix " Jiapeng Chong
2021-04-22 21:56 ` Daniel Borkmann
2021-04-23 11:57 ` Abaci Robot
2021-04-23 16:47 ` Alexei Starovoitov
2021-03-18 1:55 Jiapeng Chong
2021-03-18 16:23 ` Daniel Borkmann
2021-04-22 8:09 ` Jiapeng Chong
2021-03-16 7:59 Jiapeng Chong
2021-03-16 23:00 ` patchwork-bot+netdevbpf
2021-03-10 6:22 Jiapeng Chong
2021-03-10 9:31 ` Yauheni Kaliuta
2021-03-10 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324202848.2ncrqbzv3dv5qifo@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=baihaowen@meizu.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).