From: Masami Hiramatsu <mhiramat@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Beau Belgrave <beaub@linux.microsoft.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-devel <linux-trace-devel@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] tracing: do not export user_events uapi
Date: Thu, 31 Mar 2022 10:22:53 +0900 [thread overview]
Message-ID: <20220331102253.8793580dbc02c93dd897e52a@kernel.org> (raw)
In-Reply-To: <20220330201755.29319-1-mathieu.desnoyers@efficios.com>
On Wed, 30 Mar 2022 16:17:55 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> In addition to mark the USER_EVENTS feature BROKEN until all interested
> parties figure out the user-space API, do not install the uapi header.
>
> This prevents situations where a non-final uapi header would end up
> being installed into a distribution image and used to build user-space
> programs that would then run against newer kernels that will implement
> user events with a different ABI.
>
> Link: https://lore.kernel.org/all/20220330155835.5e1f6669@gandalf.local.home
>
Looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
> include/uapi/Kbuild | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild
> index 61ee6e59c930..425ea8769ddc 100644
> --- a/include/uapi/Kbuild
> +++ b/include/uapi/Kbuild
> @@ -12,3 +12,6 @@ ifeq ($(wildcard $(objtree)/arch/$(SRCARCH)/include/generated/uapi/asm/kvm_para.
> no-export-headers += linux/kvm_para.h
> endif
> endif
> +
> +# API is not finalized
> +no-export-headers += linux/user_events.h
> --
> 2.20.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2022-03-31 1:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 20:17 [PATCH] tracing: do not export user_events uapi Mathieu Desnoyers
2022-03-30 20:21 ` Steven Rostedt
2022-03-31 7:29 ` Masahiro Yamada
2022-03-31 12:13 ` Steven Rostedt
2022-03-31 14:41 ` Masahiro Yamada
2022-03-31 14:48 ` Steven Rostedt
2022-03-31 16:07 ` Mathieu Desnoyers
2022-03-31 17:17 ` Steven Rostedt
2022-03-31 1:22 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331102253.8793580dbc02c93dd897e52a@kernel.org \
--to=mhiramat@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=beaub@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).