From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3E7C433EF for ; Sun, 3 Apr 2022 14:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235494AbiDCOlb (ORCPT ); Sun, 3 Apr 2022 10:41:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbiDCOla (ORCPT ); Sun, 3 Apr 2022 10:41:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19363205E1; Sun, 3 Apr 2022 07:39:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6109611C9; Sun, 3 Apr 2022 14:39:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934EBC340ED; Sun, 3 Apr 2022 14:39:34 +0000 (UTC) Date: Sun, 3 Apr 2022 10:39:33 -0400 From: Steven Rostedt To: LKML , Linus Torvalds Cc: Beau Belgrave , Masami Hiramatsu , linux-trace-devel , bpf , Network Development , Mathieu Desnoyers , Alexei Starovoitov Subject: Re: [PATCH v2] tracing: Set user_events to BROKEN Message-ID: <20220403103933.787cc4de@rorschach.local.home> In-Reply-To: <20220330155835.5e1f6669@gandalf.local.home> References: <20220330155835.5e1f6669@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 30 Mar 2022 15:58:35 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > After being merged, user_events become more visible to a wider audience > that have concerns with the current API. It is too late to fix this for > this release, but instead of a full revert, just mark it as BROKEN (which > prevents it from being selected in make config). Then we can work finding > a better API. If that fails, then it will need to be completely reverted. > > Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/ > > Signed-off-by: Steven Rostedt (Google) Linus, I noticed that you pulled in this patch (slightly updated subject). I had it part of my queue that was going thought my tests, which have just finished. I was going to send you a pull request today. Is it OK that I keep that patch? Otherwise, I need to pull it out and rerun my tests without it. I would have had this to you earlier but because of the merge conflicts of my last pull request that this queue depended on, I based all my new changes off of the merge commit you had made with my previous pull request, and that contained bugs that would prevent my tests from passing (as you saw with the one memory mapping issue). I'll go ahead and send you the pull request that I have that contains this patch as well, but feel free to reject it if you want me to redo my queue without it. -- Steve