From: Kui-Feng Lee <kuifeng@fb.com>
To: <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andrii@kernel.org>, <kernel-team@fb.com>
Cc: Kui-Feng Lee <kuifeng@fb.com>
Subject: [PATCH bpf-next v5 0/5] Attach a cookie to a tracing program.
Date: Tue, 12 Apr 2022 09:55:50 -0700 [thread overview]
Message-ID: <20220412165555.4146407-1-kuifeng@fb.com> (raw)
Allow users to attach a 64-bits cookie to a bpf_link of fentry, fexit,
or fmod_ret.
This patchset includes several major changes.
- Define struct bpf_tramp_links to replace bpf_tramp_prog.
struct bpf_tramp_links collects bpf_links of a trampoline
- Generate a trampoline to call bpf_progs of given bpf_links.
- Trampolines always set/reset bpf_run_ctx before/after
calling/leaving a tracing program.
- Attach a cookie to a bpf_link of fentry/fexit/fmod_ret. The value
will be available when running the associated bpf_prog.
The major differences from v4:
- Remove condition checking in __bpf_prog_{enter,exit)
The major differences from v3:
- rebase v3 to latest tip.
The major differences from v2:
- Move the allocations of run_ctx (struct bpf_tramp_run_ctx) out of
invoke_bpf_prog().
- Move hlist_node out of bpf_link and introduce struct bpf_tramp_link
to own hlist_node.
- Store cookies at struct bpf_tracing_link.
- Use SIB byte to reduce the number of instructions to set cookie
values. (Use RSP directly)
v1: https://lore.kernel.org/all/20220126214809.3868787-1-kuifeng@fb.com/
v2: https://lore.kernel.org/bpf/20220316004231.1103318-1-kuifeng@fb.com/
v3: https://lore.kernel.org/bpf/20220407192552.2343076-1-kuifeng@fb.com/
v4: https://lore.kernel.org/bpf/20220411173429.4139609-1-kuifeng@fb.com/
Kui-Feng Lee (5):
bpf, x86: Generate trampolines from bpf_tramp_links
bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack
bpf, x86: Attach a cookie to fentry/fexit/fmod_ret.
lib/bpf: Assign cookies to links in libbpf.
selftest/bpf: The test cses of BPF cookie for fentry/fexit/fmod_ret.
arch/x86/net/bpf_jit_comp.c | 98 +++++++++++++++----
include/linux/bpf.h | 56 ++++++++---
include/linux/bpf_types.h | 1 +
include/uapi/linux/bpf.h | 9 ++
kernel/bpf/bpf_struct_ops.c | 69 ++++++++-----
kernel/bpf/syscall.c | 57 +++++++----
kernel/bpf/trampoline.c | 93 +++++++++++-------
kernel/trace/bpf_trace.c | 17 ++++
net/bpf/bpf_dummy_struct_ops.c | 35 ++++++-
tools/bpf/bpftool/link.c | 1 +
tools/include/uapi/linux/bpf.h | 8 ++
tools/lib/bpf/bpf.c | 7 ++
tools/lib/bpf/bpf.h | 3 +
tools/lib/bpf/libbpf.c | 33 +++++++
tools/lib/bpf/libbpf.h | 12 +++
tools/lib/bpf/libbpf.map | 1 +
.../selftests/bpf/prog_tests/bpf_cookie.c | 52 ++++++++++
.../selftests/bpf/progs/test_bpf_cookie.c | 24 +++++
18 files changed, 459 insertions(+), 117 deletions(-)
--
2.30.2
next reply other threads:[~2022-04-12 16:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 16:55 Kui-Feng Lee [this message]
2022-04-12 16:55 ` [PATCH bpf-next v5 1/5] bpf, x86: Generate trampolines from bpf_tramp_links Kui-Feng Lee
2022-04-13 2:43 ` Andrii Nakryiko
2022-04-13 17:53 ` Kui-Feng Lee
2022-04-13 19:08 ` Andrii Nakryiko
2022-04-12 16:55 ` [PATCH bpf-next v5 2/5] bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack Kui-Feng Lee
2022-04-13 2:55 ` Andrii Nakryiko
2022-04-13 18:06 ` Kui-Feng Lee
2022-04-13 20:14 ` Kui-Feng Lee
2022-04-12 16:55 ` [PATCH bpf-next v5 3/5] bpf, x86: Attach a cookie to fentry/fexit/fmod_ret Kui-Feng Lee
2022-04-13 3:03 ` Andrii Nakryiko
2022-04-13 18:14 ` Kui-Feng Lee
2022-04-12 16:55 ` [PATCH bpf-next v5 4/5] lib/bpf: Assign cookies to links in libbpf Kui-Feng Lee
2022-04-13 3:14 ` Andrii Nakryiko
2022-04-12 16:55 ` [PATCH bpf-next v5 5/5] selftest/bpf: The test cses of BPF cookie for fentry/fexit/fmod_ret Kui-Feng Lee
2022-04-13 3:17 ` Andrii Nakryiko
2022-04-13 18:30 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412165555.4146407-1-kuifeng@fb.com \
--to=kuifeng@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).