From: Martin KaFai Lau <kafai@fb.com>
To: Jie Meng <jmeng@fb.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: Make SYN ACK RTO tunable by BPF programs with TFO
Date: Tue, 16 Aug 2022 09:59:33 -0700 [thread overview]
Message-ID: <20220816165933.j7nsql7e7dytwoj4@kafai-mbp> (raw)
In-Reply-To: <20220815202900.3961097-1-jmeng@fb.com>
On Mon, Aug 15, 2022 at 01:29:00PM -0700, Jie Meng wrote:
> Instead of the hardcoded TCP_TIMEOUT_INIT, this diff calls tcp_timeout_init
> to initiate req->timeout like the non TFO SYN ACK case.
>
> Tested using the following packetdrill script, on a host with a BPF
> program that sets the initial connect timeout to 10ms.
>
> `../../common/defaults.sh`
>
> // Initialize connection
> 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
> +0 setsockopt(3, SOL_TCP, TCP_FASTOPEN, [1], 4) = 0
> +0 bind(3, ..., ...) = 0
> +0 listen(3, 1) = 0
>
> +0 < S 0:0(0) win 32792 <mss 1000,sackOK,FO TFO_COOKIE>
> +0 > S. 0:0(0) ack 1 <mss 1460,nop,nop,sackOK>
> +.01 > S. 0:0(0) ack 1 <mss 1460,nop,nop,sackOK>
> +.02 > S. 0:0(0) ack 1 <mss 1460,nop,nop,sackOK>
> +.04 > S. 0:0(0) ack 1 <mss 1460,nop,nop,sackOK>
> +.01 < . 1:1(0) ack 1 win 32792
>
> +0 accept(3, ..., ...) = 4
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2022-08-16 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 20:29 [PATCH net-next] tcp: Make SYN ACK RTO tunable by BPF programs with TFO Jie Meng
2022-08-16 13:36 ` Neal Cardwell
2022-08-16 16:11 ` Yuchung Cheng
2022-08-16 16:59 ` Martin KaFai Lau [this message]
2022-08-17 9:30 ` patchwork-bot+netdevbpf
[not found] <20220806000635.472853-1-jmeng@fb.com>
2022-08-10 22:30 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816165933.j7nsql7e7dytwoj4@kafai-mbp \
--to=kafai@fb.com \
--cc=bpf@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jmeng@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).