From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73269ECAAD8 for ; Wed, 14 Sep 2022 11:20:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiINLUM (ORCPT ); Wed, 14 Sep 2022 07:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiINLUI (ORCPT ); Wed, 14 Sep 2022 07:20:08 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D104A2FFF3; Wed, 14 Sep 2022 04:20:06 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D4C875C016D; Wed, 14 Sep 2022 07:20:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Sep 2022 07:20:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lmb.io; h=cc:cc :content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663154405; x=1663240805; bh=g5 nrhku7XzOq1sKHPJflx7TIWuD1FqVOgdP2P6w9enc=; b=WsybmA4GEiX2AoM+AQ SMLx9NbIM2YpucB2Gyf6h+yyPAoaT+NquJaqqm60VxCsYNFd5numGa98kIIYkN9R j4BCw8hBqTUsOT7b7sBZCKU94oSc96qcekYNaGQpDG6UOuxKUS5xB8XNZMjbhgzB +jrHH3oDZnJM+WPw22x6Kgvc/r3+tk3qXJCBKITAzskEsNArLR7W+i2SujyRuNdn X7MWbINNyL/ECmg0pUGJ3zL4xpwsXT4C2JBMV5U1sj660AxkMVH58qgHwYxRcFqY ongOnEZFCMEh/5jSKyId6oSx7e9EwDAo+ff/YQhP+UcMUcZhh/1GvaWUGwUPrV2G 9XNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663154405; x=1663240805; bh=g5nrhku7XzOq1 sKHPJflx7TIWuD1FqVOgdP2P6w9enc=; b=boZ1l8ntoCcSTeNPdTmksFTkU15Nq meXMrwqbtUlWftVSVsrdsvUKw3OMvGJY6bkD9+9Fni/VFqh0YIZ0/cKw7+JUI61y WHK9li6/mp6tbV3F7PKrulAKhxhWx1ENgzEFpFozUpZVc8lXKROIxhPvhzCOGmU6 rx7myiUIbp18YCR/2yjRzIh82U+CihyJCZqYwTPAXrFNeZl4q0xZzn/0fc5///6F KjcUQ0zQDatAKhg68iWrcnEa4iMveqmk2gp2dpBF4nNxKIvhYjFlo3Hes+5W5EUV k78N7GTo98aN9aPd3EDmZY2kBU+m9meFgDUAMqDm/cOSI38r5C3MipFwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefnohhrvghniicuuegruhgvrhcuoehoshhssehlmhgsrdhi oheqnecuggftrfgrthhtvghrnhepfeegledtgeehgeekgfffteeihfevieejhedvudeuie euhefgvdevudevteefvdetnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoshhssehlmhgsrd hioh X-ME-Proxy: Feedback-ID: icd3146c6:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 07:20:03 -0400 (EDT) From: Lorenz Bauer To: shaozhengchao@huawei.com, ast@kernel.org, daniel@iogearbox.net Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, sdf@google.com, yuehaibing@huawei.com, Lorenz Bauer Subject: Re: [PATCH v4,bpf-next] bpf: Don't redirect packets with invalid pkt_len Date: Wed, 14 Sep 2022 11:19:36 +0000 Message-Id: <20220914111936.19881-1-oss@lmb.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220715115559.139691-1-shaozhengchao@huawei.com> References: <20220715115559.139691-1-shaozhengchao@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi, I think this patch is causing user-space breakage, see [0]. The gist is that we do BPF_PROG_RUN of a socket filter with 14 byte input to determine whether BPF_PROG_RUN is available or not. I'll fix this in cilium/ebpf, but I think this patch needs more work since users may be doing the same thing in their code. Thanks, Lorenz 0: https://github.com/cilium/ebpf/pull/788