From: Stanislav Fomichev <sdf@google.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org
Subject: [PATCH bpf] bpf: make DEBUG_INFO_BTF_MODULES selectable independently
Date: Tue, 4 Oct 2022 15:27:25 -0700 [thread overview]
Message-ID: <20221004222725.2813510-1-sdf@google.com> (raw)
We're having an issue where we have a recent clang that seems
to generate kind_flag for enums (aka, adding signed/unsigned).
Trying to install a module on a kernel that doesn't have commit
6089fb325cf7 ("bpf: Add btf enum64 support") returns the following:
[ 3.176954] BPF:Invalid btf_info kind_flag
The enum that it complains about doesn't seem to have anything special
except having a sign:
[1721] ENUM 'perf_event_state' encoding=SIGNED size=4 vlen=6
'PERF_EVENT_STATE_DEAD' val=-4
'PERF_EVENT_STATE_EXIT' val=-3
'PERF_EVENT_STATE_ERROR' val=-2
'PERF_EVENT_STATE_OFF' val=-1
'PERF_EVENT_STATE_INACTIVE' val=0
'PERF_EVENT_STATE_ACTIVE' val=1
We are not currently using CONFIG_DEBUG_INFO_BTF_MODULES and
don't plan to use module BTF, so it's preferable to be able
to explicits disable it in the kernel config. Unfortunately,
because that kconfig option doesn't have a name, it's not
possible to flip it independently from CONFIG_DEBUG_INFO_BTF.
Let's add a name to make sure module BTF is user-controllable.
(Not sure, but maybe the right fix is to also have a stable patch
to relax that "Invalid btf_info kind_flag" check?)
Fixes: 5f9ae91f7c0d ("kbuild: Build kernel module BTFs if BTF is enabled and pahole supports it")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c77fe36bb3d8..6336a697c9f5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -326,6 +326,7 @@ config PAHOLE_HAS_SPLIT_BTF
def_bool $(success, test `$(PAHOLE) --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/'` -ge "119")
config DEBUG_INFO_BTF_MODULES
+ bool "Generate BTF module typeinfo"
def_bool y
depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF
help
--
2.38.0.rc1.362.ged0d419d3c-goog
next reply other threads:[~2022-10-04 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 22:27 Stanislav Fomichev [this message]
2022-10-05 0:33 ` [PATCH bpf] bpf: make DEBUG_INFO_BTF_MODULES selectable independently sdf
2022-10-05 1:39 ` Alexei Starovoitov
2022-10-05 2:04 ` Stanislav Fomichev
2022-10-05 23:28 ` Andrii Nakryiko
2022-10-06 7:21 ` Jiri Olsa
2022-10-06 16:20 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004222725.2813510-1-sdf@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).