From: Xu Kuohai <xukuohai@huaweicloud.com>
To: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH bpf-next] selftests/bpf: Remove two infinite loop bound check cases
Date: Mon, 27 Mar 2023 11:35:38 -0400 [thread overview]
Message-ID: <20230327153538.850440-1-xukuohai@huaweicloud.com> (raw)
From: Xu Kuohai <xukuohai@huawei.com>
The two infinite loop bound check cases added by commit
1a3148fc171f ("selftests/bpf: Check when bounds are not in the 32-bit range")
take a long time to execute but don't add much value.
Remove them to reduce run time of test_verifier.
Fixes: 1a3148fc171f ("selftests/bpf: Check when bounds are not in the 32-bit range")
Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
---
tools/testing/selftests/bpf/verifier/bounds.c | 50 -------------------
1 file changed, 50 deletions(-)
diff --git a/tools/testing/selftests/bpf/verifier/bounds.c b/tools/testing/selftests/bpf/verifier/bounds.c
index 74b1917d4208..515a8222f08f 100644
--- a/tools/testing/selftests/bpf/verifier/bounds.c
+++ b/tools/testing/selftests/bpf/verifier/bounds.c
@@ -777,31 +777,6 @@
.result = ACCEPT,
.prog_type = BPF_PROG_TYPE_XDP,
},
-{
- "bound check with JMP_JSLT for crossing 64-bit signed boundary",
- .insns = {
- BPF_LDX_MEM(BPF_W, BPF_REG_2, BPF_REG_1, offsetof(struct xdp_md, data)),
- BPF_LDX_MEM(BPF_W, BPF_REG_3, BPF_REG_1, offsetof(struct xdp_md, data_end)),
- BPF_MOV64_REG(BPF_REG_1, BPF_REG_2),
- BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, 1),
- BPF_JMP_REG(BPF_JGT, BPF_REG_1, BPF_REG_3, 8),
-
- BPF_LDX_MEM(BPF_B, BPF_REG_1, BPF_REG_2, 0),
- BPF_LD_IMM64(BPF_REG_0, 0x7fffffffffffff10),
- BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_0),
-
- BPF_LD_IMM64(BPF_REG_0, 0x8000000000000000),
- BPF_ALU64_IMM(BPF_ADD, BPF_REG_0, 1),
- /* r1 signed range is [S64_MIN, S64_MAX] */
- BPF_JMP_REG(BPF_JSLT, BPF_REG_0, BPF_REG_1, -2),
-
- BPF_MOV64_IMM(BPF_REG_0, 0),
- BPF_EXIT_INSN(),
- },
- .errstr = "BPF program is too large",
- .result = REJECT,
- .prog_type = BPF_PROG_TYPE_XDP,
-},
{
"bound check for loop upper bound greater than U32_MAX",
.insns = {
@@ -849,28 +824,3 @@
.result = ACCEPT,
.prog_type = BPF_PROG_TYPE_XDP,
},
-{
- "bound check with JMP32_JSLT for crossing 32-bit signed boundary",
- .insns = {
- BPF_LDX_MEM(BPF_W, BPF_REG_2, BPF_REG_1, offsetof(struct xdp_md, data)),
- BPF_LDX_MEM(BPF_W, BPF_REG_3, BPF_REG_1, offsetof(struct xdp_md, data_end)),
- BPF_MOV64_REG(BPF_REG_1, BPF_REG_2),
- BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, 1),
- BPF_JMP_REG(BPF_JGT, BPF_REG_1, BPF_REG_3, 6),
-
- BPF_LDX_MEM(BPF_B, BPF_REG_1, BPF_REG_2, 0),
- BPF_MOV32_IMM(BPF_REG_0, 0x7fffff10),
- BPF_ALU32_REG(BPF_ADD, BPF_REG_1, BPF_REG_0),
-
- BPF_MOV32_IMM(BPF_REG_0, 0x80000000),
- BPF_ALU32_IMM(BPF_ADD, BPF_REG_0, 1),
- /* r1 signed range is [S32_MIN, S32_MAX] */
- BPF_JMP32_REG(BPF_JSLT, BPF_REG_0, BPF_REG_1, -2),
-
- BPF_MOV64_IMM(BPF_REG_0, 0),
- BPF_EXIT_INSN(),
- },
- .errstr = "BPF program is too large",
- .result = REJECT,
- .prog_type = BPF_PROG_TYPE_XDP,
-},
--
2.30.2
next reply other threads:[~2023-03-27 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 15:35 Xu Kuohai [this message]
2023-03-27 3:20 ` [PATCH bpf-next] selftests/bpf: Remove two infinite loop bound check cases Andrii Nakryiko
2023-03-27 6:20 ` Xu Kuohai
2023-03-27 18:55 ` Andrii Nakryiko
2023-03-28 12:19 ` Xu Kuohai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327153538.850440-1-xukuohai@huaweicloud.com \
--to=xukuohai@huaweicloud.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).