bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Yosry Ahmed <yosryahmed@google.com>, Tejun Heo <tj@kernel.org>,
	Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vasily Averin <vasily.averin@linux.dev>,
	cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	bpf@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v3 4/8] memcg: replace stats_flush_lock with an atomic
Date: Tue, 4 Apr 2023 19:32:09 +0200	[thread overview]
Message-ID: <20230404173209.fuw2wdbhbzdgszc6@blackpad> (raw)
In-Reply-To: <CALvZod7Ao-VmB4as+VHsR+awW1jmOA18uVM7qk21mVsXTOYC2A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Tue, Apr 04, 2023 at 10:21:33AM -0700, Shakeel Butt <shakeelb@google.com> wrote:
> > Yes indeed it is. Basically we want to avoid unconditional cache
> > dirtying. This pattern is also used at other places in the kernel like
> > qspinlock.

Thanks for confirmation.

(I remembered the commit 873f64b791a2 ("mm/memcontrol.c: remove the
redundant updating of stats_flush_threshold"). But was slightly confused
why would it be open-coded every time.)

> Oh also take a look at
> https://lore.kernel.org/all/20230404052228.15788-1-feng.tang@intel.com/

Thanks for the link.

Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-04-04 17:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 19:17 [PATCH v3 0/8] memcg: avoid flushing stats atomically where possible Yosry Ahmed
2023-03-30 19:17 ` [PATCH v3 1/8] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" Yosry Ahmed
2023-03-30 19:17 ` [PATCH v3 2/8] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" Yosry Ahmed
2023-03-30 19:17 ` [PATCH v3 3/8] memcg: do not flush stats in irq context Yosry Ahmed
2023-03-30 19:17 ` [PATCH v3 4/8] memcg: replace stats_flush_lock with an atomic Yosry Ahmed
2023-04-04 16:52   ` Michal Koutný
2023-04-04 17:13     ` Shakeel Butt
2023-04-04 17:21       ` Shakeel Butt
2023-04-04 17:32         ` Michal Koutný [this message]
2023-03-30 19:17 ` [PATCH v3 5/8] memcg: sleep during flushing stats in safe contexts Yosry Ahmed
2023-03-30 19:30   ` Johannes Weiner
2023-04-04 15:09   ` Johannes Weiner
2023-03-30 19:17 ` [PATCH v3 6/8] workingset: memcg: sleep when flushing stats in workingset_refault() Yosry Ahmed
2023-04-04 16:53   ` Michal Koutný
2023-04-04 18:09     ` Yosry Ahmed
2023-04-05  8:00       ` Michal Koutný
2023-04-05  8:02         ` Yosry Ahmed
2023-03-30 19:18 ` [PATCH v3 7/8] vmscan: memcg: sleep when flushing stats during reclaim Yosry Ahmed
2023-03-30 19:18 ` [PATCH v3 8/8] memcg: do not modify rstat tree for zero updates Yosry Ahmed
2023-04-04 16:53   ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404173209.fuw2wdbhbzdgszc6@blackpad \
    --to=mkoutny@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=tj@kernel.org \
    --cc=vasily.averin@linux.dev \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).