From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Tejun Heo <tj@kernel.org>
Cc: Dmitry Yakunin <zeil@yandex-team.ru>,
davem@davemloft.net, netdev@vger.kernel.org,
cgroups@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v3 net] inet_diag: add cgroup id attribute
Date: Fri, 3 Apr 2020 17:56:01 +0300 [thread overview]
Message-ID: <20ba0af2-66df-00da-104a-512990c316d8@yandex-team.ru> (raw)
In-Reply-To: <20200403144505.GZ162390@mtj.duckdns.org>
On 03/04/2020 17.45, Tejun Heo wrote:
> On Fri, Apr 03, 2020 at 05:37:17PM +0300, Konstantin Khlebnikov wrote:
>>> How would this work with things like inetd? Would it make sense to associate the
>>> socket on the first actual send/recv?
>>
>> First send/recv seems too intrusive.
>
> Intrusive in terms of?
In term of adding more code to networking fast paths.
>
>> Setsockopt to change association to current cgroup (or by id) seems more reasonable.
>
> I'm not sure about exposing it as an explicit interface.
Yep, it's better to create thing in right place from the beginning.
Current behaviour isn't bad, just not obvious (and barely documented).
That's why I've asked Dmitry to add these notes.
>
> Thanks.
>
next prev parent reply other threads:[~2020-04-03 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:56 [PATCH v3 net] inet_diag: add cgroup id attribute Dmitry Yakunin
2020-04-03 13:38 ` Tejun Heo
2020-04-03 13:41 ` Tejun Heo
2020-04-03 14:37 ` Konstantin Khlebnikov
2020-04-03 14:45 ` Tejun Heo
2020-04-03 14:56 ` Konstantin Khlebnikov [this message]
2020-04-03 23:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ba0af2-66df-00da-104a-512990c316d8@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zeil@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).