From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com
Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH v3 bpf-next 0/2] Make bpf_endian.h compatible with vmlinux.h
Date: Wed, 1 Jul 2020 16:53:51 +0200 [thread overview]
Message-ID: <2170175d-a97e-6ca5-003c-bc6d6d1b936a@iogearbox.net> (raw)
In-Reply-To: <20200630152125.3631920-1-andriin@fb.com>
On 6/30/20 5:21 PM, Andrii Nakryiko wrote:
> Change libbpf's bpf_endian.h header to be compatible when used with system
> headers and when using just vmlinux.h. This is a frequent request for users
> writing BPF CO-RE applications. Do this by re-implementing byte swap
> compile-time macros. Also add simple tests validating correct results both for
> byte-swapping built-ins and macros.
>
> v2->v3:
> - explicit zero-initialization of global variables (Daniel);
>
> v1->v2:
> - reimplement byte swapping macros (Alexei).
>
> Andrii Nakryiko (2):
> libbpf: make bpf_endian co-exist with vmlinux.h
> selftests/bpf: add byte swapping selftest
>
> tools/lib/bpf/bpf_endian.h | 43 ++++++++++++---
> .../testing/selftests/bpf/prog_tests/endian.c | 53 +++++++++++++++++++
> .../testing/selftests/bpf/progs/test_endian.c | 37 +++++++++++++
> 3 files changed, 125 insertions(+), 8 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/endian.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_endian.c
>
All good now & applied, thanks!
prev parent reply other threads:[~2020-07-01 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 15:21 [PATCH v3 bpf-next 0/2] Make bpf_endian.h compatible with vmlinux.h Andrii Nakryiko
2020-06-30 15:21 ` [PATCH v3 bpf-next 1/2] libbpf: make bpf_endian co-exist " Andrii Nakryiko
2020-06-30 15:21 ` [PATCH v3 bpf-next 2/2] selftests/bpf: add byte swapping selftest Andrii Nakryiko
2020-06-30 18:09 ` [PATCH v3 bpf-next 0/2] Make bpf_endian.h compatible with vmlinux.h Yonghong Song
2020-07-01 14:53 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2170175d-a97e-6ca5-003c-bc6d6d1b936a@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).