From: David Ahern <dsahern@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Rumen Telbizov <rumen.telbizov@menlosecurity.com>
Cc: bpf@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup
Date: Wed, 30 Jun 2021 08:26:37 -0600 [thread overview]
Message-ID: <23256157-cbd1-f616-858a-efa63dd2c43b@gmail.com> (raw)
In-Reply-To: <YNwCiZpNoKaL6fa1@kroah.com>
On 6/29/21 11:35 PM, Greg KH wrote:
> On Tue, Jun 29, 2021 at 11:55:35AM -0700, Rumen Telbizov wrote:
>> From: David Ahern <dsahern@kernel.org>
>>
>> Add support for policy routing via marks to the bpf_fib_lookup
>> helper. The bpf_fib_lookup struct is constrained to 64B for
>> performance. Since the smac and dmac entries are used only for
>> output, put them in an anonymous struct and then add a union
>> around a second struct that contains the mark to use in the FIB
>> lookup.
>>
>> Signed-off-by: Rumen Telbizov <rumen.telbizov@menlosecurity.com>
>> ---
>
> Any reason that David didn't also sign off on this?
>
I did; just confusion by a first timer in taking my patch and adding his
patches to it. It will be fixed in v2.
next prev parent reply other threads:[~2021-06-30 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 18:55 [PATCH 0/3] Add support for fwmark to bpf_fib_lookup Rumen Telbizov
2021-06-29 18:55 ` [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup Rumen Telbizov
2021-06-30 5:35 ` Greg KH
2021-06-30 14:26 ` David Ahern [this message]
2021-06-29 18:55 ` [PATCH 2/3] tools: Update bpf header Rumen Telbizov
2021-06-29 18:55 ` [PATCH 3/3] selftests: Add selftests for fwmark support in bpf_fib_lookup Rumen Telbizov
2021-06-29 23:08 ` Yonghong Song
-- strict thread matches above, loose matches on Subject: below --
2021-06-29 17:37 [PATCH 1/3] bpf: Add support for mark with bpf_fib_lookup Rumen Telbizov
2021-06-29 17:50 ` Greg KH
2021-06-29 17:50 ` Greg KH
2021-06-29 19:10 ` David Ahern
2021-06-29 17:51 ` Toke Høiland-Jørgensen
2021-06-29 18:06 ` Rumen Telbizov
2021-06-29 18:13 ` Greg KH
2021-06-29 18:22 ` Rumen Telbizov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23256157-cbd1-f616-858a-efa63dd2c43b@gmail.com \
--to=dsahern@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=rumen.telbizov@menlosecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).