From: Yonghong Song <yhs@fb.com>
To: Martin KaFai Lau <kafai@fb.com>, <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eric Dumazet <edumazet@google.com>, <kernel-team@fb.com>,
Neal Cardwell <ncardwell@google.com>, <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH bpf-next 0/8] bpf: Allow bpf tcp iter to do bpf_setsockopt
Date: Tue, 29 Jun 2021 12:04:21 -0700 [thread overview]
Message-ID: <255586ce-81c3-bcf2-663c-f89fa18c0ac0@fb.com> (raw)
In-Reply-To: <20210625200446.723230-1-kafai@fb.com>
On 6/25/21 1:04 PM, Martin KaFai Lau wrote:
> This set is to allow bpf tcp iter to call bpf_setsockopt.
>
> With bpf-tcp-cc, new algo rollout happens more often. Instead of
> restarting the applications to pick up the new tcp-cc, this set
> allows the bpf tcp iter with the netadmin cap to call
> bpf_setsockopt(TCP_CONGESTION). It is not limited to TCP_CONGESTION
> and the bpf tcp iter can call bpf_setsockopt() with other options.
> The bpf tcp iter can read into all the fields of a tcp_sock, so
> there is a lot of flexibility to select the desired sk to do
> setsockopt(), e.g. it can test for TCP_LISTEN only and leave
> the established connections untouched, or check the addr/port,
> or check the current tcp-cc name, ...etc.
>
> Patch 1-4 are some cleanup and prep work in the tcp and bpf seq_file.
>
> Patch 5 is to have the tcp seq_file iterate on the
> port+addr lhash2 instead of the port only listening_hash.
>
> Patch 6 is to have the bpf tcp iter doing batching which
> then allows lock_sock. lock_sock is needed for setsockopt.
>
> Patch 7 allows the bpf tcp iter to call bpf_setsockopt.
>
> Martin KaFai Lau (8):
> tcp: seq_file: Avoid skipping sk during tcp_seek_last_pos
> tcp: seq_file: Refactor net and family matching
> bpf: tcp: seq_file: Remove bpf_seq_afinfo from tcp_iter_state
> tcp: seq_file: Add listening_get_first()
> tcp: seq_file: Replace listening_hash with lhash2
> bpf: tcp: bpf iter batching and lock_sock
> bpf: tcp: Support bpf_setsockopt in bpf tcp iter
> bpf: selftest: Test batching and bpf_setsockopt in bpf tcp iter
>
> include/linux/bpf.h | 7 +
> include/net/inet_hashtables.h | 6 +
> include/net/tcp.h | 1 -
> kernel/bpf/bpf_iter.c | 22 +
> kernel/trace/bpf_trace.c | 7 +-
> net/core/filter.c | 17 +
> net/ipv4/tcp_ipv4.c | 409 ++++++++++++++----
> tools/testing/selftests/bpf/network_helpers.c | 85 +++-
> tools/testing/selftests/bpf/network_helpers.h | 4 +
> .../bpf/prog_tests/bpf_iter_setsockopt.c | 226 ++++++++++
> .../selftests/bpf/progs/bpf_iter_setsockopt.c | 76 ++++
> .../selftests/bpf/progs/bpf_tracing_net.h | 4 +
> 12 files changed, 767 insertions(+), 97 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c
> create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_setsockopt.c
I have a few minor comments (replying to individual commits). But
overall LGTM.
Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2021-06-29 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 20:04 [PATCH bpf-next 0/8] bpf: Allow bpf tcp iter to do bpf_setsockopt Martin KaFai Lau
2021-06-25 20:04 ` [PATCH bpf-next 1/8] tcp: seq_file: Avoid skipping sk during tcp_seek_last_pos Martin KaFai Lau
2021-06-25 20:04 ` [PATCH bpf-next 2/8] tcp: seq_file: Refactor net and family matching Martin KaFai Lau
2021-06-25 20:05 ` [PATCH bpf-next 3/8] bpf: tcp: seq_file: Remove bpf_seq_afinfo from tcp_iter_state Martin KaFai Lau
2021-06-25 20:05 ` [PATCH bpf-next 4/8] tcp: seq_file: Add listening_get_first() Martin KaFai Lau
2021-06-25 20:05 ` [PATCH bpf-next 5/8] tcp: seq_file: Replace listening_hash with lhash2 Martin KaFai Lau
2021-06-25 20:05 ` [PATCH bpf-next 6/8] bpf: tcp: bpf iter batching and lock_sock Martin KaFai Lau
2021-06-29 17:27 ` Yonghong Song
2021-06-29 17:44 ` Martin KaFai Lau
2021-06-29 17:57 ` Yonghong Song
2021-06-29 18:06 ` Martin KaFai Lau
2021-06-29 18:55 ` Yonghong Song
2021-06-25 20:05 ` [PATCH bpf-next 7/8] bpf: tcp: Support bpf_setsockopt in bpf tcp iter Martin KaFai Lau
2021-06-25 20:05 ` [PATCH bpf-next 8/8] bpf: selftest: Test batching and " Martin KaFai Lau
2021-06-29 19:00 ` Yonghong Song
2021-06-29 19:04 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=255586ce-81c3-bcf2-663c-f89fa18c0ac0@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).