bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 bpf-next 0/3] fix BTF verification size resolution
@ 2019-07-11  6:53 Andrii Nakryiko
  2019-07-11  6:53 ` [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic Andrii Nakryiko
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Andrii Nakryiko @ 2019-07-11  6:53 UTC (permalink / raw)
  To: bpf, netdev, ast, daniel, yhs
  Cc: andrii.nakryiko, kernel-team, Andrii Nakryiko

BTF size resolution logic isn't always resolving type size correctly, leading
to erroneous map creation failures due to value size mismatch.

This patch set:
1. fixes the issue (patch #1);
2. adds tests for trickier cases (patch #2);
3. and converts few test cases utilizing BTF-defined maps, that previously
   couldn't use typedef'ed arrays due to kernel bug (patch #3).

Patch #1 can be applied against bpf tree, but selftest ones (#2 and #3) have
to go against bpf-next for now.

Andrii Nakryiko (3):
  bpf: fix BTF verifier size resolution logic
  selftests/bpf: add trickier size resolution tests
  selftests/bpf: use typedef'ed arrays as map values

 kernel/bpf/btf.c                              | 14 ++-
 .../bpf/progs/test_get_stack_rawtp.c          |  3 +-
 .../bpf/progs/test_stacktrace_build_id.c      |  3 +-
 .../selftests/bpf/progs/test_stacktrace_map.c |  2 +-
 tools/testing/selftests/bpf/test_btf.c        | 88 +++++++++++++++++++
 5 files changed, 102 insertions(+), 8 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-07-12 17:10 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11  6:53 [PATCH v2 bpf-next 0/3] fix BTF verification size resolution Andrii Nakryiko
2019-07-11  6:53 ` [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic Andrii Nakryiko
2019-07-12  5:59   ` Yonghong Song
2019-07-12 15:36     ` Andrii Nakryiko
2019-07-12 15:47       ` Yonghong Song
2019-07-12 17:10         ` Andrii Nakryiko
2019-07-11  6:53 ` [PATCH v2 bpf-next 2/3] selftests/bpf: add trickier size resolution tests Andrii Nakryiko
2019-07-11  6:53 ` [PATCH v2 bpf-next 3/3] selftests/bpf: use typedef'ed arrays as map values Andrii Nakryiko
2019-07-12  6:03 ` [PATCH v2 bpf-next 0/3] fix BTF verification size resolution Yonghong Song
2019-07-12 12:59   ` Daniel Borkmann
2019-07-12 15:42     ` Andrii Nakryiko
2019-07-12 15:51       ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).