bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Cc: David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	bpf@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
	Daniel Borkmann <borkmann@iogearbox.net>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage
Date: Fri, 29 Jan 2021 20:47:41 +0100	[thread overview]
Message-ID: <28a12f2b-3c46-c428-ddc2-de702ef33d3f@gmail.com> (raw)
In-Reply-To: <20210129113555.6d361580@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>



On 1/29/21 8:35 PM, Jakub Kicinski wrote:

> kdoc didn't complain, and as you say it's already a mess, plus it's
> two screen-fulls of scrolling away... 
> 
> I think converting to inline kdoc of members would be an improvement,
> if you want to sign up for that? Otherwise -EDIDNTCARE on my side :)
> 

What about removing this kdoc ?

kdoc for a huge structure is mostly useless...


  reply	other threads:[~2021-01-29 19:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 17:39 [PATCH net-next V1] net: adjust net_device layout for cacheline usage Jesper Dangaard Brouer
2021-01-29  3:51 ` David Ahern
2021-01-29  7:58   ` Jesper Dangaard Brouer
     [not found]     ` <20210129114642.139cb7dc@carbon>
2021-01-29 19:35       ` Jakub Kicinski
2021-01-29 19:47         ` Eric Dumazet [this message]
2021-01-29 20:07           ` Jakub Kicinski
2021-02-12 15:57             ` Jesper Dangaard Brouer
2021-01-29  4:50 ` patchwork-bot+netdevbpf
     [not found] ` <52835f1f-96e1-b36e-2631-1182649ac3a8@gmail.com>
     [not found]   ` <20210129150058.34e3a855@carbon>
2021-02-12 15:49     ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28a12f2b-3c46-c428-ddc2-de702ef33d3f@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=borkmann@iogearbox.net \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).