From: Yonghong Song <yhs@fb.com>
To: Lorenz Bauer <lmb@cloudflare.com>, <daniel@iogearbox.com>,
<ast@kernel.org>, <bpf@vger.kernel.org>
Cc: <kernel-team@cloudflare.com>, Ivan Babrou <ivan@cloudflare.com>
Subject: Re: [PATCH bpf] scripts: require pahole v1.16 when generating BTF
Date: Mon, 8 Jun 2020 10:33:05 -0700 [thread overview]
Message-ID: <3318a5fa-e4c0-67a7-0d69-9eb16d397f73@fb.com> (raw)
In-Reply-To: <20200608094257.47366-1-lmb@cloudflare.com>
On 6/8/20 2:42 AM, Lorenz Bauer wrote:
> bpf_iter requires the kernel BTF to be generated with
> pahole >= 1.16, since otherwise the function definitions
> that the iterator attaches to are not included.
> This failure mode is indistiguishable from trying to attach
> to an iterator that really doesn't exist.
>
> Since it's really easy to miss this requirement, bump the
> pahole version check used at build time to at least 1.16.
>
> Fixes: 15d83c4d7cef ("bpf: Allow loading of a bpf_iter program")
> Suggested-by: Ivan Babrou <ivan@cloudflare.com>
> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2020-06-08 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:42 [PATCH bpf] scripts: require pahole v1.16 when generating BTF Lorenz Bauer
2020-06-08 17:33 ` Yonghong Song [this message]
2020-06-09 18:08 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3318a5fa-e4c0-67a7-0d69-9eb16d397f73@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.com \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=lmb@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).