From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A76AC282DD for ; Thu, 23 May 2019 14:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E5512175B for ; Thu, 23 May 2019 14:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="B/Y4fH6Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730875AbfEWOb3 (ORCPT ); Thu, 23 May 2019 10:31:29 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41836 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730756AbfEWOb2 (ORCPT ); Thu, 23 May 2019 10:31:28 -0400 Received: by mail-wr1-f68.google.com with SMTP id u16so2653949wrn.8 for ; Thu, 23 May 2019 07:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oitixCSyls+WYiarRC0a38mP4/mPHlJWvdjbHhBfuHw=; b=B/Y4fH6Qgs2zYncTUWrRBciMLNiyA1JzQ+6IFRwIVufOmOufnPzzI1bl9Hs37qOk2w APLNK6ED2e/jKD0/9FWVcR8OJkrnxL6OARAdbkmtNXaAGeKFS2XNBTmlIF3UUEITyQYY l5DRGg9Cd2cCXEOeQjDS2fX6CKYTieotF7b6/sI9oatoAJ/wc67l+GFLAxdL0riWCQLm Zil0wZ/8U9gLAvMQvTEI88tWK3D3mtWyX2fb7NavstFsm3wkaoLU0O9yTxeh60wC8Vfa /89K6IQIi3Hw07k3OrJ1OgXHX1I13qX/2/j657OgX1qljfcWjyEO34w4VItOyNs/4UjC PnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oitixCSyls+WYiarRC0a38mP4/mPHlJWvdjbHhBfuHw=; b=E7cIDyFgORJKkSEn7uhp1owofIMORqArhXwOAPOQP+/pN+5dZTgUsp2DD08btRJYP7 x408ABpCg3sBTBj/nFQ6eRBXjVmN++NIQuSz8UsRWyDoWrpTQI2xpxEcAAEAOCzCaBhT 48bHOZVLad7qXCi+GV+ZeWqja+JA7T2IeBUiPKNv62+q9YgrDgR+ObCrzkx7sXziBsqH /4vWdosjiAbebZiz3vnm6GlTWC7YhAsZdjii/DqpF2aL9tsf65rwTpACt0F9TdmTHinJ jOqHA8go+a8gKqeZT98jo/T7p6RBjuLAJaBuRjYhE/IeFEFoPsncUJJwTbgyBaoR88Wz dgYQ== X-Gm-Message-State: APjAAAWGShPs0n01YCLDuuGwKUIfFmfdpxcbZ325bTO0Y4Uc675akNsg YbZOGLMEEfojt+9FqJXbKu/D2w== X-Google-Smtp-Source: APXvYqzLpgvV703PNCaOR0gIk35TrvPQMaresROkLbWDiJ/l3GB8TuILzZw00e4zoaFvppE2r535cQ== X-Received: by 2002:adf:e4c9:: with SMTP id v9mr35521866wrm.147.1558621886783; Thu, 23 May 2019 07:31:26 -0700 (PDT) Received: from [172.20.1.229] ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id o4sm11751807wmo.20.2019.05.23.07.31.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 07:31:26 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor From: Jiong Wang In-Reply-To: Date: Thu, 23 May 2019 15:31:24 +0100 Cc: Y Song , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexei Starovoitov , netdev , bpf Content-Transfer-Encoding: quoted-printable Message-Id: <3ED3A4F8-CC01-4179-9154-6FC5338E83B5@netronome.com> References: <20190522092323.17435-1-bjorn.topel@gmail.com> To: Daniel Borkmann X-Mailer: Apple Mail (2.3273) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org > On 23 May 2019, at 15:02, Daniel Borkmann = wrote: >=20 > On 05/23/2019 08:38 AM, Y Song wrote: >> On Wed, May 22, 2019 at 1:46 PM Bj=C3=B6rn T=C3=B6pel = wrote: >>> On Wed, 22 May 2019 at 20:13, Y Song wrote: >>>> On Wed, May 22, 2019 at 2:25 AM Bj=C3=B6rn T=C3=B6pel = wrote: >>>>>=20 >>>>> Add three tests to test_verifier/basic_instr that make sure that = the >>>>> high 32-bits of the destination register is cleared after an ALU32 >>>>> and/or/xor. >>>>>=20 >>>>> Signed-off-by: Bj=C3=B6rn T=C3=B6pel >>>>=20 >>>> I think the patch intends for bpf-next, right? The patch itself = looks >>>> good to me. >>>> Acked-by: Yonghong Song >>>=20 >>> Thank you. Actually, it was intended for the bpf tree, as a test >>> follow up for this [1] fix. >> Then maybe you want to add a Fixes tag and resubmit? >=20 > Why would the test case need a fixes tag? It's common practice that we = have > BPF fixes that we queue to bpf tree along with kselftest test cases = related > to them. Therefore, applied as well, thanks for following up! >=20 > Bj=C3=B6rn, in my email from the fix, I mentioned we should have test = snippets > ideally for all of the alu32 insns to not miss something falling = through the > cracks when JITs get added or changed. If you have some cycles to add = the > remaining missing ones, that would be much appreciated. Bj=C3=B6rn, If you don=E2=80=99t have time, I can take this alu32 test case follow = up as well. Regards, Jiong >=20 > Thanks, > Daniel