From: Yonghong Song <yhs@fb.com>
To: KP Singh <kpsingh@chromium.org>, James Morris <jmorris@namei.org>,
<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Florent Revest <revest@chromium.org>,
Brendan Jackman <jackmanb@chromium.org>,
Mimi Zohar <zohar@linux.ibm.com>
Subject: Re: [PATCH bpf-next v3 1/3] ima: Implement ima_inode_hash
Date: Tue, 24 Nov 2020 09:35:02 -0800 [thread overview]
Message-ID: <3b6f7023-e1fe-b79b-fa06-b8edcce530de@fb.com> (raw)
In-Reply-To: <20201124151210.1081188-2-kpsingh@chromium.org>
On 11/24/20 7:12 AM, KP Singh wrote:
> From: KP Singh <kpsingh@google.com>
>
> This is in preparation to add a helper for BPF LSM programs to use
> IMA hashes when attached to LSM hooks. There are LSM hooks like
> inode_unlink which do not have a struct file * argument and cannot
> use the existing ima_file_hash API.
>
> An inode based API is, therefore, useful in LSM based detections like an
> executable trying to delete itself which rely on the inode_unlink LSM
> hook.
>
> Moreover, the ima_file_hash function does nothing with the struct file
> pointer apart from calling file_inode on it and converting it to an
> inode.
>
> Signed-off-by: KP Singh <kpsingh@google.com>
There is no change for this patch compared to previous version,
so you can carry my Ack.
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2020-11-24 17:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:12 [PATCH bpf-next v3 0/3] Implement bpf_ima_inode_hash KP Singh
2020-11-24 15:12 ` [PATCH bpf-next v3 1/3] ima: Implement ima_inode_hash KP Singh
2020-11-24 17:35 ` Yonghong Song [this message]
2020-11-25 12:04 ` KP Singh
2020-11-25 12:17 ` Daniel Borkmann
2020-11-25 12:27 ` Mimi Zohar
2020-11-24 15:12 ` [PATCH bpf-next v3 2/3] bpf: Add a BPF helper for getting the IMA hash of an inode KP Singh
2020-11-24 17:41 ` Yonghong Song
2020-11-24 15:12 ` [PATCH bpf-next v3 3/3] bpf: Add a selftest for bpf_ima_inode_hash KP Singh
2020-11-24 18:07 ` Yonghong Song
2020-11-25 2:20 ` Mimi Zohar
2020-11-25 2:55 ` KP Singh
2020-11-25 3:01 ` Mimi Zohar
2020-11-25 12:27 ` Mimi Zohar
2020-11-26 6:27 ` Yonghong Song
2020-11-26 15:18 ` KP Singh
2020-11-27 4:29 ` Andrii Nakryiko
2020-11-27 13:09 ` KP Singh
2020-11-25 23:10 ` [PATCH bpf-next v3 0/3] Implement bpf_ima_inode_hash patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b6f7023-e1fe-b79b-fa06-b8edcce530de@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jackmanb@chromium.org \
--cc=jmorris@namei.org \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=revest@chromium.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).