bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	makita.toshiaki@lab.ntt.co.jp, daniel@iogearbox.net,
	ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: bjorn.topel@intel.com, magnus.karlsson@intel.com
Subject: Re: [PATCH bpf] veth: store queue_mapping independently of XDP prog presence
Date: Fri, 5 Mar 2021 23:50:23 +0900	[thread overview]
Message-ID: <3c05a530-633b-03ce-2362-8dc9d5a76d98@gmail.com> (raw)
In-Reply-To: <20210303152903.11172-1-maciej.fijalkowski@intel.com>

On 2021/03/04 0:29, Maciej Fijalkowski wrote:
> Currently, veth_xmit() would call the skb_record_rx_queue() only when
> there is XDP program loaded on peer interface in native mode.
> 
> If peer has XDP prog in generic mode, then netif_receive_generic_xdp()
> has a call to netif_get_rxqueue(skb), so for multi-queue veth it will
> not be possible to grab a correct rxq.
> 
> To fix that, store queue_mapping independently of XDP prog presence on
> peer interface.
> 
> Fixes: 638264dc9022 ("veth: Support per queue XDP ring")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

I did like this in order to keep the default behavior for non-xdp case,
but generic XDP should behave the same as native XDP, so

Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>

  reply	other threads:[~2021-03-05 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 15:29 [PATCH bpf] veth: store queue_mapping independently of XDP prog presence Maciej Fijalkowski
2021-03-05 14:50 ` Toshiaki Makita [this message]
2021-03-05 23:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c05a530-633b-03ce-2362-8dc9d5a76d98@gmail.com \
    --to=toshiaki.makita1@gmail.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).