bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: "Daniel T. Lee" <danieltimlee@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Andrii Nakryiko" <andriin@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] samples: bpf: fix outdated README build command
Date: Mon, 11 Nov 2019 14:58:30 +0100	[thread overview]
Message-ID: <3db9a7b0-c218-693c-98c5-a45b69429b8a@iogearbox.net> (raw)
In-Reply-To: <20191110081901.20851-1-danieltimlee@gmail.com>

On 11/10/19 9:19 AM, Daniel T. Lee wrote:
> Currently, building the bpf samples under samples/bpf directory isn't
> working. Running make from the directory 'samples/bpf' will just shows
> following result without compiling any samples.
> 
>   $ make
>   make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/linux/samples/bpf
>   make[1]: Entering directory '/git/linux'
>     CALL    scripts/checksyscalls.sh
>     CALL    scripts/atomic/check-atomics.sh
>     DESCEND  objtool
>   make[1]: Leaving directory '/git/linux'
> 
> Due to commit 394053f4a4b3 ("kbuild: make single targets work more
> correctly"), building samples/bpf without support of samples/Makefile
> is unavailable. Instead, building the samples with 'make M=samples/bpf'
> from the root source directory will solve this issue.[1]
> 
> This commit fixes the outdated README build command with samples/bpf.
> 
> [0]: https://patchwork.kernel.org/patch/11168393/
> 
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>

Thanks for the patch, Daniel! Looks like it's not rebased to the latest bpf-next
tree and therefore doesn't apply cleanly.

Meanwhile, https://patchwork.ozlabs.org/patch/1192639/ was sent which addresses
the same issue.

Best,
Daniel

  parent reply	other threads:[~2019-11-11 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10  8:19 [PATCH] samples: bpf: fix outdated README build command Daniel T. Lee
2019-11-11  6:09 ` Andrii Nakryiko
2019-11-11  9:24   ` Toke Høiland-Jørgensen
2019-11-12 11:47     ` Daniel T. Lee
2019-11-12 11:45   ` Daniel T. Lee
2019-11-11 13:58 ` Daniel Borkmann [this message]
2019-11-12 11:48   ` Daniel T. Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3db9a7b0-c218-693c-98c5-a45b69429b8a@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=danieltimlee@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).