bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn.topel@intel.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Björn Töpel" <bjorn.topel@gmail.com>,
	ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Cc: maciej.fijalkowski@intel.com, hawk@kernel.org,
	magnus.karlsson@intel.com, john.fastabend@gmail.com,
	kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions
Date: Fri, 19 Feb 2021 18:49:06 +0100	[thread overview]
Message-ID: <3e3e61af-b6e0-0755-f5f1-39fcd4e47f2d@intel.com> (raw)
In-Reply-To: <87r1lchtkf.fsf@toke.dk>

On 2021-02-19 18:10, Toke Høiland-Jørgensen wrote:
>> +	case XDP_REDIR_DEV_MAP: {
>>   		struct bpf_dtab_netdev *dst = fwd;
> I thought the braces around the case body looked a bit odd. I guess
> that's to get a local scope for the dst var (and xs var below), right?
> This is basically a cast, though, so I wonder if you couldn't just as
> well use the fwd pointer directly (with a cast) in the function call
> below? WDYT?

Yeah. I'll fix that in the next verison!


Thanks, and have a nice weekend!
Björn

      reply	other threads:[~2021-02-19 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 14:59 [PATCH bpf-next 0/2] Optimize bpf_redirect_map()/xdp_do_redirect() Björn Töpel
2021-02-19 14:59 ` [PATCH bpf-next 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP Björn Töpel
2021-02-19 17:05   ` Toke Høiland-Jørgensen
2021-02-19 17:47     ` Björn Töpel
2021-02-19 17:08   ` kernel test robot
2021-02-19 18:13   ` kernel test robot
2021-02-19 14:59 ` [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions Björn Töpel
2021-02-19 17:10   ` Toke Høiland-Jørgensen
2021-02-19 17:49     ` Björn Töpel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e3e61af-b6e0-0755-f5f1-39fcd4e47f2d@intel.com \
    --to=bjorn.topel@intel.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    --subject='Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).