From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B04C4320A for ; Tue, 31 Aug 2021 09:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C0A860F6B for ; Tue, 31 Aug 2021 09:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240286AbhHaJnj (ORCPT ); Tue, 31 Aug 2021 05:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233015AbhHaJnh (ORCPT ); Tue, 31 Aug 2021 05:43:37 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABFADC061575; Tue, 31 Aug 2021 02:42:42 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id v10so26658594wrd.4; Tue, 31 Aug 2021 02:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Ojwl8/djIVLrJT34N5n/ZmuYzmO6v/z2g4THD9il8B8=; b=rV10iB4cww2liOe6PvrelTOApV3cUrlSL+9ucNmAC80Aj8rgUeXHG+JEG3w4nVaWlx LKkuBoGmM57JqtvKPkV69KOC/VwsVjUsHibSfdofrsvW5LhgHjle680rrV0Z7Inmreq9 sI8Mhv8kQwgLYthylYPB01+AISczfqRe+7Ktp4NnufhgVctyVGqzl3JDGZZkiUP7BLud +gSTtmylcA/KgvKF0SdkBsZjEU1pqXvdX0wtybStmbXkrdTZFkLP+V36YX7fhMiWbca8 JQ1bNTL2AvfQedt4xV/X5Mq5D1TISjGjSByRHrMbGsw4pLU4vas6cHDK3nJA8eQsj6PJ DspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ojwl8/djIVLrJT34N5n/ZmuYzmO6v/z2g4THD9il8B8=; b=Bu6kGAIyY3V6S3+lzczbwBZ5lsVlbDt3vEFQoDLvhLw/tDpMCrpVnd+UQWL1NYOS2/ CIszCSD9cJD182V/kXDR7O4PmsdKS85/TsVo0Tv3v+pgdX8Tyhlp2Ev91KBV8IvA4PUg HiX6PsXe4tCetIuGGAXpdA3Gklc6hmluaFufu7VjDiw/MESsjYFwQBzJZFFgKwe46SSw DNMsuVZy+CS9GliVgtw2tLnGX/cD/UQ5u5Xo8REHYE5gcuUh8JKnO7Orpwbn3lwhr5JB N3RaesjDCCHTr8ZJdBZHKKybZGd54WdMEsmLRBwnMEIyIuhd6ffEGsHOaPIXdRVMsUwl Qiuw== X-Gm-Message-State: AOAM531yeuz/9l4dpFZtpXhKg3BFYfej2mY/M4FvFuSJHHdwxSrfNEyv Dp4slTB4Qg1n2bJkPOyr2P2K4wel5T0= X-Google-Smtp-Source: ABdhPJzTRFWA+GSUAhv11f0Ebl+HeBVZGJs7eZrydcbA4LIuDeqfyV9Q3jUGdWxnK+VGAnTAnbPPwA== X-Received: by 2002:a5d:4591:: with SMTP id p17mr30349623wrq.57.1630402961186; Tue, 31 Aug 2021 02:42:41 -0700 (PDT) Received: from [192.168.8.197] ([148.252.133.138]) by smtp.gmail.com with ESMTPSA id j207sm2100809wmj.40.2021.08.31.02.42.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 02:42:40 -0700 (PDT) Subject: Re: [syzbot] general protection fault in sock_from_file To: Hao Xu , Jens Axboe , syzbot , andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, dvyukov@google.com, io-uring@vger.kernel.org, john.fastabend@gmail.com, kafai@fb.com, kpsingh@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, yhs@fb.com References: <00000000000059117905cacce99e@google.com> <7949b7a0-fec1-34a7-aaf5-cbe07c6127ed@kernel.dk> From: Pavel Begunkov Message-ID: <407ce02f-7a0a-4eb2-b242-188fc605012c@gmail.com> Date: Tue, 31 Aug 2021 10:42:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 8/31/21 10:19 AM, Hao Xu wrote: > 在 2021/8/31 上午10:14, Jens Axboe 写道: >> On 8/30/21 2:45 PM, syzbot wrote: >>> syzbot has found a reproducer for the following issue on: >>> >>> HEAD commit:    93717cde744f Add linux-next specific files for 20210830 >>> git tree:       linux-next >>> console output: https://syzkaller.appspot.com/x/log.txt?x=15200fad300000 >>> kernel config:  https://syzkaller.appspot.com/x/.config?x=c643ef5289990dd1 >>> dashboard link: https://syzkaller.appspot.com/bug?extid=f9704d1878e290eddf73 >>> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1 >>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=111f5f9d300000 >>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1651a415300000 >>> >>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>> Reported-by: syzbot+f9704d1878e290eddf73@syzkaller.appspotmail.com >>> >>> general protection fault, probably for non-canonical address 0xdffffc0000000005: 0000 [#1] PREEMPT SMP KASAN >>> KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f] >>> CPU: 0 PID: 6548 Comm: syz-executor433 Not tainted 5.14.0-next-20210830-syzkaller #0 >>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >>> RIP: 0010:sock_from_file+0x20/0x90 net/socket.c:505 >>> Code: f5 ff ff ff c3 0f 1f 44 00 00 41 54 53 48 89 fb e8 85 e9 62 fa 48 8d 7b 28 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <80> 3c 02 00 75 4f 45 31 e4 48 81 7b 28 80 f1 8a 8a 74 0c e8 58 e9 >>> RSP: 0018:ffffc90002caf8e8 EFLAGS: 00010206 >>> RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000 >>> RDX: 0000000000000005 RSI: ffffffff8713203b RDI: 0000000000000028 >>> RBP: ffff888019fc0780 R08: ffffffff899aee40 R09: ffffffff81e21978 >>> R10: 0000000000000027 R11: 0000000000000009 R12: dffffc0000000000 >>> R13: 1ffff110033f80f9 R14: 0000000000000003 R15: ffff888019fc0780 >>> FS:  00000000013b5300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 >>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> CR2: 00000000004ae0f0 CR3: 000000001d355000 CR4: 00000000001506f0 >>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >>> Call Trace: >>>   io_sendmsg+0x98/0x640 fs/io_uring.c:4681 >>>   io_issue_sqe+0x14de/0x6ba0 fs/io_uring.c:6578 >>>   __io_queue_sqe+0x90/0xb50 fs/io_uring.c:6864 >>>   io_req_task_submit+0xbf/0x1b0 fs/io_uring.c:2218 >>>   tctx_task_work+0x166/0x610 fs/io_uring.c:2143 >>>   task_work_run+0xdd/0x1a0 kernel/task_work.c:164 >>>   tracehook_notify_signal include/linux/tracehook.h:212 [inline] >>>   handle_signal_work kernel/entry/common.c:146 [inline] >>>   exit_to_user_mode_loop kernel/entry/common.c:172 [inline] >>>   exit_to_user_mode_prepare+0x256/0x290 kernel/entry/common.c:209 >>>   __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline] >>>   syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:302 >>>   do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 >>>   entry_SYSCALL_64_after_hwframe+0x44/0xae >>> RIP: 0033:0x43fd49 >> >> Hao, this is due to: >> >> commit a8295b982c46d4a7c259a4cdd58a2681929068a9 >> Author: Hao Xu >> Date:   Fri Aug 27 17:46:09 2021 +0800 >> >>      io_uring: fix failed linkchain code logic >> >> which causes some weirdly super long chains from that single sqe. >> Can you take a look, please? > Sure, I'm working on this. Ah, saw it after sending a patch. It's nothing too curious, just a small error in logic. More interesting that we don't have a test case covering it, we should definitely add something. -- Pavel Begunkov