bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, brouer@redhat.com,
	lorenzo.bianconi@redhat.com
Subject: Re: [PATCH bpf-next 2/2] net: xdp: introduce xdp_build_skb_from_frame utility routine
Date: Thu, 17 Dec 2020 22:12:18 +0900	[thread overview]
Message-ID: <434e65f4-0b29-3bfb-b5d3-7eebcdd791db@gmail.com> (raw)
In-Reply-To: <9d24e4c90c91aa2d9de413ee38adc4e8e44fc81a.1608142960.git.lorenzo@kernel.org>

On 2020/12/17 3:38, Lorenzo Bianconi wrote:
> Introduce xdp_build_skb_from_frame utility routine to build the skb
> from xdp_frame. Respect to __xdp_build_skb_from_frame,
> xdp_build_skb_from_frame will allocate the skb object. Rely on
> xdp_build_skb_from_frame in veth driver.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Thanks.
It seems you added missing metadata support in veth_xdp_rcv_one()?
It might be better to note that in the commitlog.

The code looks fine to me.

Reviewed-by: Toshiaki Makita <toshiaki.makita1@gmail.com>

  reply	other threads:[~2020-12-17 13:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:38 [PATCH bpf-next 0/2] add xdp_build_skb_from_frame utility routine Lorenzo Bianconi
2020-12-16 18:38 ` [PATCH bpf-next 1/2] net: xdp: introduce __xdp_build_skb_from_frame " Lorenzo Bianconi
2021-01-12 16:46   ` Jesper Dangaard Brouer
2020-12-16 18:38 ` [PATCH bpf-next 2/2] net: xdp: introduce xdp_build_skb_from_frame " Lorenzo Bianconi
2020-12-17 13:12   ` Toshiaki Makita [this message]
2021-01-12 16:50   ` Jesper Dangaard Brouer
2021-01-12 16:08 ` [PATCH bpf-next 0/2] add " Lorenzo Bianconi
2021-01-12 16:50   ` Daniel Borkmann
2021-01-12 16:53     ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434e65f4-0b29-3bfb-b5d3-7eebcdd791db@gmail.com \
    --to=toshiaki.makita1@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).