From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC4DC761A6 for ; Thu, 30 Mar 2023 18:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbjC3SND (ORCPT ); Thu, 30 Mar 2023 14:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjC3SNC (ORCPT ); Thu, 30 Mar 2023 14:13:02 -0400 Received: from out-47.mta1.migadu.com (out-47.mta1.migadu.com [IPv6:2001:41d0:203:375::2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF5BB74F for ; Thu, 30 Mar 2023 11:13:01 -0700 (PDT) Message-ID: <4512b372-048d-d433-ca4c-4b4f34dfb646@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680199979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkl+BQInnGj4oVoMRepKOyH23KklN4hM4of+SyvIEbA=; b=QT0GrWOAznSW6lEfkkBHzwJZrXOeYWQCGNvbpAek7+gmHFx3pTpnzm+tm21+xYjpw9XLg4 A/pmGQ1eaIh5Sk+wKCikTrP7cG8XdSZG81wo37En82+2QjhlTovVvPI6QFAoaQkBUqEbmJ oU2UBS0Y0onKX/FKJX2SzvZzPygC9xY= Date: Thu, 30 Mar 2023 11:12:56 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v3 bpf-next 5/5] selftests/bpf: Add bench for task storage creation Content-Language: en-US To: James Hilliard Cc: bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@meta.com, "Jose E. Marchesi" , David Faust References: <20230322215246.1675516-1-martin.lau@linux.dev> <20230322215246.1675516-6-martin.lau@linux.dev> <456bcd47-efa2-7e3d-78c0-5f41ecba477c@linux.dev> <2b5b56bb-7160-41ac-1fb8-4dbc6ad67d9f@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 3/30/23 12:51 AM, James Hilliard wrote: > On Wed, Mar 29, 2023 at 2:07 PM Martin KaFai Lau wrote: >> >> On 3/29/23 1:03 PM, James Hilliard wrote: >>>>> So it looks like fork is translated to __gcov_fork when -std=gnu* is set which >>>>> is why we get this error. >>>>> >>>>> As this appears to be intended behavior for gcc I think the best option is >>>>> to just rename the function so that we don't run into issues when building >>>>> with gnu extensions like -std=gnu11. >>>> Is it sure 'fork' is the only culprit? If not, it is better to address it >>>> properly because this unnecessary name change is annoying when switching bpf >>>> prog from clang to gcc. Like changing the name in this .c here has to make >>>> another change to the .c in the prog_tests/ directory. >>> We've fixed a similar issue in the past by renaming to avoid a >>> conflict with the builtin: >>> https://github.com/torvalds/linux/commit/ab0350c743d5c93fd88742f02b3dff12168ab435 >>> >> >> Fair enough. Please post a patch for the name change. > > Any suggestions/preferences on what name I should use instead? May be 'sched_process_fork'? that will make it the same as the tracepoint's name.