From: Yonghong Song <yhs@fb.com>
To: Jiri Olsa <jolsa@redhat.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>
Subject: Re: [PATCH bpf-next 1/2] libbpf: Do not use btf_dump__new macro for c++ objects
Date: Thu, 23 Dec 2021 08:13:01 -0800 [thread overview]
Message-ID: <48c1e6bf-ee4b-bf49-ec85-2cec98ab9dcb@fb.com> (raw)
In-Reply-To: <20211223131736.483956-1-jolsa@kernel.org>
On 12/23/21 5:17 AM, Jiri Olsa wrote:
> As reported in here [0], C++ compilers don't support __builtin_types_compatible_p(),
> so at least don't screw up compilation for them and let C++ users
> pick btf_dump__new vs btf_dump__new_deprecated explicitly.
>
> [0] https://github.com/libbpf/libbpf/issues/283#issuecomment-986100727
> Fixes: 6084f5dc928f ("libbpf: Ensure btf_dump__new() and btf_dump_opts are future-proof")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2021-12-23 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 13:17 [PATCH bpf-next 1/2] libbpf: Do not use btf_dump__new macro for c++ objects Jiri Olsa
2021-12-23 13:17 ` [PATCH bpf-next 2/2] selftests/bpf: Add btf_dump__new to test_cpp Jiri Olsa
2021-12-23 16:14 ` Yonghong Song
2021-12-23 16:13 ` Yonghong Song [this message]
2021-12-23 18:25 ` [PATCH bpf-next 1/2] libbpf: Do not use btf_dump__new macro for c++ objects Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c1e6bf-ee4b-bf49-ec85-2cec98ab9dcb@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).