From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B867FC64E7B for ; Fri, 27 Nov 2020 09:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 797462222C for ; Fri, 27 Nov 2020 09:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MycJzaG7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728285AbgK0JVv (ORCPT ); Fri, 27 Nov 2020 04:21:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbgK0JVu (ORCPT ); Fri, 27 Nov 2020 04:21:50 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9E1C0613D4 for ; Fri, 27 Nov 2020 01:21:50 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id i2so4813611wrs.4 for ; Fri, 27 Nov 2020 01:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=4haAtXUHa8qd3ezJgcItd1OHQbgYPxsuO+gzkuxGWzA=; b=MycJzaG7hTHxWNHLHRT7gLb1N4CWd4edFBx5g/7f2oTSaPmbzk/tc1/iqIIhvyDeWO MuVBINQE+vBa4ymeSmrzOACpGRntflnD1ruPWTH3gHMTljUdlCxb41AdeWXCzy3VEHc4 T+dx8lWWcjRnmoFI1iOhctgKBT5HI0cqaDL+A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4haAtXUHa8qd3ezJgcItd1OHQbgYPxsuO+gzkuxGWzA=; b=IFsfAw5joAFIXZaM3L1y256QuyO57AfFr2iPcmuTFUBdFbHJMFZcH7qvF/ovEUlX2M cPKnOdi+2xtItbwdXvSXD/uO9YRMDLULhnLrW3Q1+cKjDbXbfTjqfypZNubF15AzuWRZ FDbOoF5r6kSyTscwFZli243PBl5eP3uf1IsGkMtx1XFYxYJGYsCPPZY+zNlx6WhLkE2G aM4UTTBwA1QvavPZ3b/+ess3C/C/lFG5/pVhEwRcw9TqzpSRAxIFH41zL+kptvX//hpg 0NQ/Nhvpqy0wPEQGnU/R6ZxxtVkNZfU9FghZt6W2QU9HIFN0mqxaVM6pwUG90T14+87I GN8Q== X-Gm-Message-State: AOAM532yKPC83lfLHkBnHV3csIhXoSQcN2I5zTpVr2eGQPUcRgpi9ChZ X4uZrP8C0SjKPj3FSTQsbfRyng== X-Google-Smtp-Source: ABdhPJxKn99M0WW71ImXjuufXD45kVFE54JjEEPi8DjQ8fwpuMovU1Kj5DqnCtQrCGWP+M0uR3DpEA== X-Received: by 2002:a5d:548b:: with SMTP id h11mr9228587wrv.306.1606468909049; Fri, 27 Nov 2020 01:21:49 -0800 (PST) Received: from ?IPv6:2a04:ee41:4:1318:ea45:a00:4d43:48fc? ([2a04:ee41:4:1318:ea45:a00:4d43:48fc]) by smtp.gmail.com with ESMTPSA id a144sm13266512wmd.47.2020.11.27.01.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 01:21:48 -0800 (PST) Message-ID: <492ad793692d03105f3ac2a2e1a3196dc01e5cef.camel@chromium.org> Subject: Re: [PATCH bpf-next v3 5/6] bpf: Add an iterator selftest for bpf_sk_storage_get From: Florent Revest To: Yonghong Song , bpf@vger.kernel.org Cc: viro@zeniv.linux.org.uk, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, andrii@kernel.org, kpsingh@chromium.org, revest@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Fri, 27 Nov 2020 10:21:44 +0100 In-Reply-To: <2c5a814a-7b69-3a8d-e4e0-e595d009cf82@fb.com> References: <20201126164449.1745292-1-revest@google.com> <20201126164449.1745292-5-revest@google.com> <2c5a814a-7b69-3a8d-e4e0-e595d009cf82@fb.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 2020-11-26 at 23:00 -0800, Yonghong Song wrote: > On 11/26/20 8:44 AM, Florent Revest wrote: > > +SEC("iter/task_file") > > +int fill_socket_owner(struct bpf_iter__task_file *ctx) > > +{ > > + struct task_struct *task = ctx->task; > > + struct file *file = ctx->file; > > + struct socket *sock; > > + int *sock_tgid; > > + > > + if (!task || !file || task->tgid != task->pid) > > task->tgid != task->pid is not needed here. > The task_file iterator already tries to skip task with task->pid > if its file table is the same as task->tgid. Good to know!