From: Daniel Borkmann <daniel@iogearbox.net>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>
Cc: Xuefeng Li <lixuefeng@loongson.cn>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] bpf: Add some description about BPF_JIT_ALWAYS_ON in Kconfig
Date: Fri, 11 Feb 2022 15:44:25 +0100 [thread overview]
Message-ID: <4b4431d4-4ad4-19b2-dd03-688165e3d470@iogearbox.net> (raw)
In-Reply-To: <1644569851-20859-2-git-send-email-yangtiezhu@loongson.cn>
On 2/11/22 9:57 AM, Tiezhu Yang wrote:
> When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> set to 1 and setting any other value than that will return in failure.
>
> Add the above description in the help text of BPF_JIT_ALWAYS_ON, and then
> we can distinguish between BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> kernel/bpf/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index d24d518..88409f8 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -58,6 +58,9 @@ config BPF_JIT_ALWAYS_ON
> Enables BPF JIT and removes BPF interpreter to avoid speculative
> execution of BPF instructions by the interpreter.
>
> + When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> + set to 1 and setting any other value than that will return in failure.
Small nit here: lets use the full path (/proc/sys/net/core/bpf_jit_enable) in order
to be consistent with the other descriptions in this Kconfig.
> config BPF_JIT_DEFAULT_ON
> def_bool ARCH_WANT_DEFAULT_BPF_JIT || BPF_JIT_ALWAYS_ON
> depends on HAVE_EBPF_JIT && BPF_JIT
>
next prev parent reply other threads:[~2022-02-11 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 8:57 [PATCH bpf-next 0/2] Modify BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON Tiezhu Yang
2022-02-11 8:57 ` [PATCH bpf-next 1/2] bpf: Add some description about BPF_JIT_ALWAYS_ON in Kconfig Tiezhu Yang
2022-02-11 14:44 ` Daniel Borkmann [this message]
2022-02-11 8:57 ` [PATCH bpf-next 2/2] bpf: Make BPF_JIT_DEFAULT_ON selectable " Tiezhu Yang
2022-02-11 10:23 ` Daniel Borkmann
2022-02-12 2:40 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4431d4-4ad4-19b2-dd03-688165e3d470@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yangtiezhu@loongson.cn \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).