From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D073C10DCE for ; Thu, 12 Mar 2020 11:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00AE42071C for ; Thu, 12 Mar 2020 11:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.b="cQipXksQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgCLLq3 (ORCPT ); Thu, 12 Mar 2020 07:46:29 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43228 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbgCLLq3 (ORCPT ); Thu, 12 Mar 2020 07:46:29 -0400 Received: by mail-wr1-f68.google.com with SMTP id b2so800470wrj.10 for ; Thu, 12 Mar 2020 04:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=inDMtYNsCPgtsoeJuXt25fIlas+Z9MXxfdx1yN6Wg68=; b=cQipXksQQTUGXw9jSh3RQsTUzScRdBgJf3JOC0nmBVxnMThl9G8MB5Ea4iVj2qam7X z0dHRM/c2adwFXW7bpNpuCjbLTVkxJX8y7TJ0atUqRvZdCelweVNJfe06G/3aQ5la991 zBY1Cv7okdypjy663mt4fLC4Ya/o3cr8s5vK3UaK9QrsUoKpI8jx8MHbouns+kGZ6CIT SUDxOHMYjJulQwNxdOYbQaYGTSKeClWSiDFpeqQvG9IMH5pgDRyKTHXfSzEqcmZtECwq XhLlhjrKF2KedfTTCFadDf+gK31jJErjaNMwrxXMopazIu5B+lGX1xR/j2g6slUUX8/h RCUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=inDMtYNsCPgtsoeJuXt25fIlas+Z9MXxfdx1yN6Wg68=; b=k+PZu8o4N+vWDLkB8J5fqZ6ONbTmv2azRfL0l516ps50IsLIodkY7ghoAB/UzI9N1i iJUYtWDGuiNuWC/me9Xrnev5duUUw7B/G1Wn0ymE6rKhmrm4UErW70KwWE9KPnj7HEEt sR2yFUXKJ06hjBypGuWwMOA4fp7bjXcawBw5Xvc4aY7JlVjGnYLPNkRaLLAYJ/CVH+g/ y7F4BqIvfoLcq/4ZwGvByxgyoCqYnOs6KOnHAQKFg6JQuN/vEcAFCIGi5XYR6UxCvyzU s8JpFDqOiI2v6z64/ymPqrTcLcqI1jX+n+9/wq6kuDLslhQDjEGPa1lRZ8uxDFcP1Hl5 tK3g== X-Gm-Message-State: ANhLgQ2jS/FiYJL2HjlgkBxWQ08ci62VRfy343vuMPQirrZ3jot1igW1 NVFO7N+IFPG3C+vSHuuqP+7PsA== X-Google-Smtp-Source: ADFU+vtPMbwWSzcprz2nw2IMfY/wjhAN16hme2jtbMi+q04V+T3u0M81RM5r9YTmeaBPdBBmqmAlOQ== X-Received: by 2002:adf:ecca:: with SMTP id s10mr11019797wro.255.1584013587896; Thu, 12 Mar 2020 04:46:27 -0700 (PDT) Received: from [192.168.1.10] ([194.35.118.177]) by smtp.gmail.com with ESMTPSA id f15sm12164113wmj.25.2020.03.12.04.46.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 04:46:27 -0700 (PDT) Subject: Re: [PATCH v2 bpf-next 1/3] bpftool: only build bpftool-prog-profile if supported by clang To: Song Liu , netdev@vger.kernel.org, bpf@vger.kernel.org Cc: john.fastabend@gmail.com, kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, arnaldo.melo@gmail.com, jolsa@kernel.org References: <20200311221844.3089820-1-songliubraving@fb.com> <20200311221844.3089820-2-songliubraving@fb.com> From: Quentin Monnet Message-ID: <50a4f620-c9ad-d17f-07ee-d7c901cb76ed@isovalent.com> Date: Thu, 12 Mar 2020 11:46:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200311221844.3089820-2-songliubraving@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 2020-03-11 15:18 UTC-0700 ~ Song Liu > bpftoo-prog-profile requires clang to generate BTF for global variables. Typo: bpftool (missing "l") > When compared with older clang, skip this command. This is achieved by > adding a new feature, clang-bpf-global-var, to tools/build/feature. > > Signed-off-by: Song Liu Works great when clang is either too old or missing, thanks! > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > index 576ddd82bc96..03b1979dfad8 100644 > --- a/tools/bpf/bpftool/prog.c > +++ b/tools/bpf/bpftool/prog.c > @@ -1545,6 +1545,8 @@ static int do_loadall(int argc, char **argv) > > static int do_profile(int argc, char **argv) > { > + fprintf(stdout, "bpftool prog profile command is not supported.\n" > + "Please build bpftool with clang >= 10.0.0\n"); Nit: Can we use p_err() instead of fprintf(), and a single-line error message please? To remain consistent and work with JSON output. Thanks, Quentin