From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C671C7D604 for ; Fri, 13 Dec 2019 20:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CFEF247D7 for ; Fri, 13 Dec 2019 20:39:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K77Tq24s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbfLMRuA (ORCPT ); Fri, 13 Dec 2019 12:50:00 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:42509 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbfLMRuA (ORCPT ); Fri, 13 Dec 2019 12:50:00 -0500 Received: by mail-pj1-f67.google.com with SMTP id o11so25497pjp.9; Fri, 13 Dec 2019 09:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1rwygl2rLQ3dreKZy28Fvryy72/v/PQU1Hd1V0ORYkk=; b=K77Tq24sdUf65wcUZJEZoyjYxi9TRoAIHwlTo7OpNLrHsc9NaITCo3EgNnlzK0ikuW /Tm1ZsJky+byFE4X7CvL0zNWSO6xVAXC5RWGLJq2sGpSgqCgQ6TAL/prVwi26UfbL+S+ kmuwCaX829n5zUkmtE1lRoyQ3E4R0R1FrxQuZOunIsf3uQwRuli1KGlf4xs2uZPNBRa3 BkF8KlGeRWjBVjUXlKn2TEYifBu+ts4FyV77Ua8c5l4bj3YS7NtPnFlC93B4KdbWd8JT vTAJ3U4bm9AosxcM+xNtBdINh+70Xzfi3+Yn9BzK/6cuLxIIPhIW/UF8MxiIZADUzt7W YgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1rwygl2rLQ3dreKZy28Fvryy72/v/PQU1Hd1V0ORYkk=; b=Gj0TAOTJJInjeo5p9Yzeg2tZMkMyii/ptfr93c2XTySOEnY9C+GFj+FfRrlZR08s7y T1z+H/4ZoIS0SAYPc6mHr2vWB/+wzAi4lP39OiBPY7pZhtQfCB5BsAbhXweWkhyIwX90 V8vHrpiGEYigrX6TWMR1shNBF+rX3P72+EeMMo8Z5U+JyixDTkslQ8rrroT1msnWto/0 e2KA3JLFwUJQVDXMtpBuRD4RqNAQHTBeXaB21yyn8xhpiZL+EvMSzkYiEIrehYmeq2mj 9fjFF0GbaPx7301D8dv1DhPcoryCZqB6mRAfivyg1FT6C2rudMufltvwhTz0ygr0bScf em0A== X-Gm-Message-State: APjAAAVeDoWA8z/Mvtc98rHQJ6q2cw6f42lWay1piQ41dLvy1FNBub4D qZ6WawDav2dHAyO1BmHQa2o= X-Google-Smtp-Source: APXvYqyoXWI8wUtsQ455GEBYepAv/eY9VpMUUX17jhDp6t2fSRmyjDHxj8mDKU5deoSW0YMB3TdcLw== X-Received: by 2002:a17:90a:a004:: with SMTP id q4mr616872pjp.106.1576259399592; Fri, 13 Dec 2019 09:49:59 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id p38sm9748528pjp.27.2019.12.13.09.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 09:49:58 -0800 (PST) Subject: Re: [PATCH bpf] bpf: clear skb->tstamp in bpf_redirect when necessary To: Lorenz Bauer , ast@kernel.org, daniel@iogearbox.net, "David S. Miller" , Jesus Sanchez-Palencia , Richard Cochran , Eric Dumazet , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-team@cloudflare.com References: <20191213154634.27338-1-lmb@cloudflare.com> From: Eric Dumazet Message-ID: <523d7946-bb5f-39a3-8969-addb564fd73c@gmail.com> Date: Fri, 13 Dec 2019 09:49:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191213154634.27338-1-lmb@cloudflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 12/13/19 7:46 AM, Lorenz Bauer wrote: > Redirecting a packet from ingress to egress by using bpf_redirect > breaks if the egress interface has an fq qdisc installed. This is the same > problem as fixed in 8203e2d8 ("net: clear skb->tstamp in forwarding paths"). > > Clear skb->tstamp when redirecting into the egress path. > > Fixes: 80b14de ("net: Add a new socket option for a future transmit time.") Please use 12 digits sha1 > Fixes: fb420d5 ("tcp/fq: move back to CLOCK_MONOTONIC") > Signed-off-by: Lorenz Bauer Thanks for fixing this !