From: Joanne Koong <joannekoong@fb.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Martin KaFai Lau" <kafai@fb.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v2 0/3] Add XDP support for bpf_load_hdr_opt
Date: Tue, 12 Oct 2021 13:51:30 -0700 [thread overview]
Message-ID: <531ae597-f749-fcea-68c5-d3e2fa80d083@fb.com> (raw)
In-Reply-To: <87v922gwnw.fsf@toke.dk>
On 10/12/21 7:11 AM, Toke Høiland-Jørgensen wrote:
> Martin KaFai Lau <kafai@fb.com> writes:
>> On Sat, Oct 09, 2021 at 12:20:27AM +0200, Toke Høiland-Jørgensen wrote:
>> [...]
>> I don't mind to go with the for_each helper. However, with another
>> thought, if it needs to call a function in the loop anyway, I think
>> it could also be done in bpf by putting a global function in a loop.
>> Need to try and double check.
> Hmm, that would be interesting if possible!
>
> -Toke
>
Martin and I tried this out. When we moved out the logic for parsing the
options into a global non-inlined function, the verifier approved the
program.
As such, I will abandon this patchset and submit a new separate patch
that will add a test to ensure we're always able to parse header options
through a global function.
Thanks for the conversation on this, Toke, Martin, and Daniel!
next prev parent reply other threads:[~2021-10-12 20:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 23:05 [PATCH bpf-next v2 0/3] Add XDP support for bpf_load_hdr_opt Joanne Koong
2021-10-06 23:05 ` [PATCH bpf-next v2 1/3] bpf/xdp: Add bpf_load_hdr_opt support for xdp Joanne Koong
2021-10-06 23:50 ` Song Liu
2021-10-06 23:05 ` [PATCH bpf-next v2 2/3] bpf/selftests: Rename test_tcp_hdr_options to test_sockops_tcp_hdr_options Joanne Koong
2021-10-06 23:47 ` Song Liu
2021-10-06 23:05 ` [PATCH bpf-next v2 3/3] bpf/selftests: Add xdp bpf_load_tcp_hdr_options tests Joanne Koong
2021-10-06 23:52 ` Song Liu
2021-10-07 14:41 ` [PATCH bpf-next v2 0/3] Add XDP support for bpf_load_hdr_opt Toke Høiland-Jørgensen
2021-10-07 20:57 ` Joanne Koong
2021-10-07 21:25 ` Daniel Borkmann
2021-10-07 23:52 ` Martin KaFai Lau
2021-10-08 22:20 ` Toke Høiland-Jørgensen
2021-10-11 18:43 ` Martin KaFai Lau
2021-10-12 14:11 ` Toke Høiland-Jørgensen
2021-10-12 20:51 ` Joanne Koong [this message]
2021-10-13 10:19 ` Toke Høiland-Jørgensen
2021-10-19 0:00 ` Alexei Starovoitov
2021-10-19 16:02 ` Yonghong Song
2021-10-19 16:10 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531ae597-f749-fcea-68c5-d3e2fa80d083@fb.com \
--to=joannekoong@fb.com \
--cc=Kernel-team@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).