From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE303C64E75 for ; Fri, 27 Nov 2020 09:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5981021D7F for ; Fri, 27 Nov 2020 09:17:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fz5Y/OBD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgK0JRh (ORCPT ); Fri, 27 Nov 2020 04:17:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgK0JRg (ORCPT ); Fri, 27 Nov 2020 04:17:36 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC3E0C0613D1 for ; Fri, 27 Nov 2020 01:17:34 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a3so5813334wmb.5 for ; Fri, 27 Nov 2020 01:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=gvSmh42j+Na69d8tYP15USmlAiPkewESLNzSugoG51g=; b=fz5Y/OBDWubrfIV5wC3zKsGHvULPNFb3V3LeKRP5jZ7ACpdD78UbvC+3qtNTDyGiWX O0O47JNeqYIjiAOXmdTgG7hu5EtAvjkuSwhcZtZXLJ97XTsmdbA8gpdahyk78uVHCrpj m7vt7HNmD3hSFr8Zq8SZ0eayoZaKeWyLbtTkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gvSmh42j+Na69d8tYP15USmlAiPkewESLNzSugoG51g=; b=YgSmqQ67wKBBkUtMnuIaAKKGbgei0+Igb/yimCgBX8YCKqSuA02ULal3AqE1oLTEMd MP8cYKT8xoetp+W6Ik22494cF0anM/L92Eg+YzgoXzz9hPIg2Uytr1V/AcJ6kS0z0KKo FKtdc1n67IOXyBXqD3Zfi2iNF0qJE+vNva0QvXLNy0JmVHBE5A0YW6TymxeAOPC7yH3l NG1slIl9iz5G/38umKy/0vfvA5o3nGs67Zj9wCW527BI/+uuC3bdQ6OKW8oYW+A85PE5 DHj8SpSnbFVrnzF6HgbWXWbRN/cL20Gx59pkOzt5MFF5vFyXNRT+gw/lhazR2q7erszW VgKQ== X-Gm-Message-State: AOAM533jAz4Qq3uwLP2dnxEtjvIfgJWdmQuukQfJxadwmTtqDY9jHVpT rzXrormMF1tpBPCOu+JDy00U5Q== X-Google-Smtp-Source: ABdhPJwS5KZGFOuX8YL+/zY/fdyGq42H90XEm3tgLHgp8cubkhwx+xPy/BmkaApl0jERo6H1UsjkJg== X-Received: by 2002:a05:600c:2159:: with SMTP id v25mr8009006wml.155.1606468653404; Fri, 27 Nov 2020 01:17:33 -0800 (PST) Received: from ?IPv6:2a04:ee41:4:1318:ea45:a00:4d43:48fc? ([2a04:ee41:4:1318:ea45:a00:4d43:48fc]) by smtp.gmail.com with ESMTPSA id v25sm5456639wmj.27.2020.11.27.01.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 01:17:32 -0800 (PST) Message-ID: <540fd8fd4542c9737224a43fa4123ceb679a7b59.camel@chromium.org> Subject: Re: [PATCH bpf-next 2/2] bpf: Add a selftest for the tracing bpf_get_socket_cookie From: Florent Revest To: Yonghong Song , bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@chromium.org, revest@google.com, linux-kernel@vger.kernel.org Date: Fri, 27 Nov 2020 10:17:31 +0100 In-Reply-To: <8b0529f0-5f1e-b403-2772-7a56c44a3a55@fb.com> References: <20201126170212.1749137-1-revest@google.com> <20201126170212.1749137-2-revest@google.com> <8b0529f0-5f1e-b403-2772-7a56c44a3a55@fb.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 2020-11-26 at 23:56 -0800, Yonghong Song wrote: > > On 11/26/20 9:02 AM, Florent Revest wrote: > > This builds up on the existing socket cookie test which checks > > whether > > the bpf_get_socket_cookie helpers provide the same value in > > cgroup/connect6 and sockops programs for a socket created by the > > userspace part of the test. > > > > Adding a tracing program to the existing objects requires a > > different > > attachment strategy and different headers. > > > > Signed-off-by: Florent Revest > > --- > > .../selftests/bpf/progs/socket_cookie_prog.c | 41 > > ++++++++++++++++--- > > .../selftests/bpf/test_socket_cookie.c | 18 +++++--- > > Do you think it is possible to migrate test_socket_cookie.c to > selftests/bpf/prog_tests so it can be part of test_progs so > it will be regularly exercised? I suppose it's possible, I can give it a try :)