bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Lorenz Bauer <lmb@cloudflare.com>, Alexei Starovoitov <ast@kernel.org>
Cc: kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 00/12] bpf: sockmap, sockhash: support storing UDP sockets
Date: Mon, 9 Mar 2020 23:44:11 +0100	[thread overview]
Message-ID: <5525dcc1-c77d-eb99-302f-2aca58ec56fc@iogearbox.net> (raw)
In-Reply-To: <20200309111243.6982-1-lmb@cloudflare.com>

On 3/9/20 12:12 PM, Lorenz Bauer wrote:
> I've adressed John's nit in patch 3, and added the reviews and acks.
> 
> Changes since v3:
> - Clarify !psock check in sock_map_link_no_progs
> 
> Changes since v2:
> - Remove sk_psock_hooks based on Jakub's idea
> - Fix reference to tcp_bpf_clone in commit message
> - Add inet_csk_has_ulp helper
> 
> Changes since v1:
> - Check newsk->sk_prot in tcp_bpf_clone
> - Fix compilation with BPF_STREAM_PARSER disabled
> - Use spin_lock_init instead of static initializer
> - Elaborate on TCPF_SYN_RECV
> - Cosmetic changes to TEST macros, and more tests
> - Add Jakub and me as maintainers
> 
> Lorenz Bauer (12):
>    bpf: sockmap: only check ULP for TCP sockets
>    skmsg: update saved hooks only once
>    bpf: tcp: move assertions into tcp_bpf_get_proto
>    bpf: tcp: guard declarations with CONFIG_NET_SOCK_MSG
>    bpf: sockmap: move generic sockmap hooks from BPF TCP
>    bpf: sockmap: simplify sock_map_init_proto
>    bpf: add sockmap hooks for UDP sockets
>    bpf: sockmap: add UDP support
>    selftests: bpf: don't listen() on UDP sockets
>    selftests: bpf: add tests for UDP sockets in sockmap
>    selftests: bpf: enable UDP sockmap reuseport tests
>    bpf, doc: update maintainers for L7 BPF
> 
>   MAINTAINERS                                   |   3 +
>   include/linux/bpf.h                           |   4 +-
>   include/linux/skmsg.h                         |  56 ++---
>   include/net/inet_connection_sock.h            |   6 +
>   include/net/tcp.h                             |  20 +-
>   include/net/udp.h                             |   5 +
>   net/core/sock_map.c                           | 157 +++++++++++---
>   net/ipv4/Makefile                             |   1 +
>   net/ipv4/tcp_bpf.c                            | 114 ++--------
>   net/ipv4/tcp_ulp.c                            |   7 -
>   net/ipv4/udp_bpf.c                            |  53 +++++
>   .../bpf/prog_tests/select_reuseport.c         |   6 -
>   .../selftests/bpf/prog_tests/sockmap_listen.c | 204 +++++++++++++-----
>   13 files changed, 402 insertions(+), 234 deletions(-)
>   create mode 100644 net/ipv4/udp_bpf.c
> 

Applied, thanks!

      parent reply	other threads:[~2020-03-09 22:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 11:12 [PATCH bpf-next v4 00/12] bpf: sockmap, sockhash: support storing UDP sockets Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 01/12] bpf: sockmap: only check ULP for TCP sockets Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 02/12] skmsg: update saved hooks only once Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 03/12] bpf: tcp: move assertions into tcp_bpf_get_proto Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 04/12] bpf: tcp: guard declarations with CONFIG_NET_SOCK_MSG Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 05/12] bpf: sockmap: move generic sockmap hooks from BPF TCP Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 06/12] bpf: sockmap: simplify sock_map_init_proto Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 07/12] bpf: add sockmap hooks for UDP sockets Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 08/12] bpf: sockmap: add UDP support Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 09/12] selftests: bpf: don't listen() on UDP sockets Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 10/12] selftests: bpf: add tests for UDP sockets in sockmap Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 11/12] selftests: bpf: enable UDP sockmap reuseport tests Lorenz Bauer
2020-03-09 11:12 ` [PATCH bpf-next v4 12/12] bpf, doc: update maintainers for L7 BPF Lorenz Bauer
2020-03-09 22:44 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5525dcc1-c77d-eb99-302f-2aca58ec56fc@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=kernel-team@cloudflare.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).