From: Yonghong Song <yhs@fb.com>
To: John Fastabend <john.fastabend@gmail.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andriin@fb.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<maciej.fijalkowski@intel.com>
Subject: Re: [PATCH bpf 0/2] bpf fix for mixed tail calls and subprograms
Date: Tue, 8 Jun 2021 23:24:11 -0700 [thread overview]
Message-ID: <588e062e-f1aa-6bc5-8011-380be7bf1176@fb.com> (raw)
In-Reply-To: <162318053542.323820.3719766457956848570.stgit@john-XPS-13-9370>
On 6/8/21 12:29 PM, John Fastabend wrote:
> We recently tried to use mixed programs that have both tail calls and
> subprograms, but it needs the attached fix. Also added a small test
> addition that will cause the failure without the fix.
>
> Thanks,
> John
>
> ---
>
> John Fastabend (2):
> bpf: Fix null ptr deref with mixed tail calls and subprogs
> bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch
>
>
> .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Don't know what happens. Apparently, the first patch made changes
in kernel/bpf/verifier.c, but it didn't show up in the above.
>
> --
>
next prev parent reply other threads:[~2021-06-09 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 19:29 [PATCH bpf 0/2] bpf fix for mixed tail calls and subprograms John Fastabend
2021-06-08 19:30 ` [PATCH bpf 1/2] bpf: Fix null ptr deref with mixed tail calls and subprogs John Fastabend
2021-06-09 6:21 ` Yonghong Song
2021-06-09 15:51 ` Maciej Fijalkowski
2021-06-09 16:23 ` John Fastabend
2021-06-08 19:30 ` [PATCH bpf 2/2] bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch John Fastabend
2021-06-09 6:22 ` Yonghong Song
2021-06-09 15:57 ` Maciej Fijalkowski
2021-06-09 16:26 ` John Fastabend
2021-06-09 16:21 ` Maciej Fijalkowski
2021-06-09 6:24 ` Yonghong Song [this message]
2021-06-09 16:17 ` [PATCH bpf 0/2] bpf fix for mixed tail calls and subprograms John Fastabend
2021-06-10 0:13 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588e062e-f1aa-6bc5-8011-380be7bf1176@fb.com \
--to=yhs@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).