From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B55C432C1 for ; Tue, 24 Sep 2019 19:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF4E1207FD for ; Tue, 24 Sep 2019 19:17:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="npKdJkon" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441901AbfIXTRH (ORCPT ); Tue, 24 Sep 2019 15:17:07 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36543 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2441899AbfIXTRH (ORCPT ); Tue, 24 Sep 2019 15:17:07 -0400 Received: by mail-pf1-f195.google.com with SMTP id y22so1937993pfr.3; Tue, 24 Sep 2019 12:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uuYvKDdlCCY0lggc9sBBXzR54+aLnXoUJm8jnQudcgU=; b=npKdJkon5qmHu+jpnZddVbrF8Pa8QGihVlW++CGVzdxayedYxp3dzYNLRYB11cF5L7 /MqRAlTN0vIKtdNhuUAac/aZw7TYMtO4xdRolhbRrYZXJ5oqKPvEQMWmaFe2fYL63jDb c02/h8rRWN1g/7pbFc/16rPH4fHQBUYq+4Kvo9b9i5GVflEQc7onbvKIX7Kxalv9eonn 3Nj7GC0X3N/00h3cxmeFOVp4Yh3S2K/7wPqFbuNQF+/GlEaUXERJxkscInYJqtnUox0H SRYQ66qFJuQcnGMHFW9hDIf2YBe/UZQT/8kk/BGUhlzdWPunls5Aamub6o9uGtrolJeM hd6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uuYvKDdlCCY0lggc9sBBXzR54+aLnXoUJm8jnQudcgU=; b=kp0AsZo8S+HRjPs5MErtqtYPmc40q6X2WS647ph8P7gtqsQitVvYPAJTAL1cH9dcEE cKQoOH1QzKY5atIqjb9VsEg+xRIeGSiv4hBe3r8a41JJlNCV0uQpK6FzxuTmFDunvEzr mm601xqK5CzG/gPtVIzllWKlqiKkhYwXHtjnT7yibjxzKZpJcIuU/oQY4EcB8eHKqjai gZgGrtUUNQgAFoqlap0ICveumturTkj0gAmIrG/W5cQF3x/7HgnFBlMb33bssCxz2Jyc qk6BMOU4wGVe7o5ThTs2nzq7qXeBh3yZerOfPnty28KsZO7PQ1laY9RvUYWsBMOzwRsb k1Kg== X-Gm-Message-State: APjAAAUQBjlDigM9cxhsN19sr0DKW5BKdjwkCDGf/15v4Fmcvflvy0iy GIQGjef4vxmSiUjdemNw3gALlfIl X-Google-Smtp-Source: APXvYqyX6VYd6yhegdHOFbFMdpSp1PJ8ZEll/P+fTVQTO9t4vYIhjdtG5duoWgLMsGAaJycf16RdQg== X-Received: by 2002:a17:90b:946:: with SMTP id dw6mr1772489pjb.48.1569352626062; Tue, 24 Sep 2019 12:17:06 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id l62sm5360360pfl.167.2019.09.24.12.17.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 12:17:05 -0700 (PDT) Subject: Re: [PATCH] kcm: use BPF_PROG_RUN To: Daniel Borkmann Cc: Alexei Starovoitov , Yonghong Song , Sami Tolvanen , "David S. Miller" , Tom Herbert , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190905211528.97828-1-samitolvanen@google.com> <0f77cc31-4df5-a74f-5b64-a1e3fc439c6d@fb.com> <048e82f4-5b31-f9f4-5bf7-82dfbf7ec8f3@gmail.com> <20190924185908.GC5889@pc-63.home> From: Eric Dumazet Message-ID: <589ccc1c-12b9-4700-f6d9-b2efd3f9a347@gmail.com> Date: Tue, 24 Sep 2019 12:17:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924185908.GC5889@pc-63.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/24/19 11:59 AM, Daniel Borkmann wrote: > On Mon, Sep 23, 2019 at 02:31:04PM -0700, Eric Dumazet wrote: >> On 9/6/19 10:06 AM, Alexei Starovoitov wrote: >>> On Fri, Sep 6, 2019 at 3:03 AM Yonghong Song wrote: >>>> On 9/5/19 2:15 PM, Sami Tolvanen wrote: >>>>> Instead of invoking struct bpf_prog::bpf_func directly, use the >>>>> BPF_PROG_RUN macro. >>>>> >>>>> Signed-off-by: Sami Tolvanen >>>> >>>> Acked-by: Yonghong Song >>> >>> Applied. Thanks >> >> Then we probably need this as well, what do you think ? > > Yep, it's broken. 6cab5e90ab2b ("bpf: run bpf programs with preemption > disabled") probably forgot about it since it wasn't using BPF_PROG_RUN() > in the first place. If you get a chance, please send a proper patch, > thanks! Sure, I will send this today.