From: David Ahern <dsahern@gmail.com>
To: Yoshiki Komachi <komachi.yoshiki@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andriin@fb.com>, KP Singh <kpsingh@chromium.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
bpf@vger.kernel.org
Subject: Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table
Date: Fri, 31 Jul 2020 11:15:19 -0600 [thread overview]
Message-ID: <5970d82b-3bb9-c78f-c53a-8a1c95a1fad7@gmail.com> (raw)
In-Reply-To: <1596170660-5582-3-git-send-email-komachi.yoshiki@gmail.com>
On 7/30/20 10:44 PM, Yoshiki Komachi wrote:
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 654c346b7d91..68800d1b8cd5 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -5084,6 +5085,46 @@ static const struct bpf_func_proto bpf_skb_fib_lookup_proto = {
> .arg4_type = ARG_ANYTHING,
> };
>
> +#if IS_ENABLED(CONFIG_BRIDGE)
> +BPF_CALL_4(bpf_xdp_fdb_lookup, struct xdp_buff *, ctx,
> + struct bpf_fdb_lookup *, params, int, plen, u32, flags)
> +{
> + struct net_device *src, *dst;
> + struct net *net;
> +
> + if (plen < sizeof(*params))
> + return -EINVAL;
I need to look at the details more closely, but on first reading 2
things caught me eye:
1. you need to make sure flags is 0 since there are no supported flags
at the moment, and
> +
> + net = dev_net(ctx->rxq->dev);
> +
> + if (is_multicast_ether_addr(params->addr) ||
> + is_broadcast_ether_addr(params->addr))
> + return BPF_FDB_LKUP_RET_NOENT;
> +
> + src = dev_get_by_index_rcu(net, params->ifindex);
> + if (unlikely(!src))
> + return -ENODEV;
> +
> + dst = br_fdb_find_port_xdp(src, params->addr, params->vlan_id);
2. this needs to be done via netdev ops to avoid referencing bridge code
which can be compiled as a module. I suspect the build robots will id
this part soon.
next prev parent reply other threads:[~2020-07-31 17:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 4:44 [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 1/3] net/bridge: Add new function to access FDB from XDP programs Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table Yoshiki Komachi
2020-07-31 11:52 ` Maciej Fijalkowski
2020-08-04 8:44 ` Yoshiki Komachi
2020-07-31 17:15 ` David Ahern [this message]
2020-08-04 11:27 ` Yoshiki Komachi
2020-08-05 16:38 ` David Ahern
2020-08-07 8:06 ` Yoshiki Komachi
2020-07-31 21:12 ` Daniel Borkmann
2020-08-05 4:45 ` Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 3/3] samples/bpf: Add a simple bridge example accelerated with XDP Yoshiki Komachi
2020-07-31 14:15 ` Jesper Dangaard Brouer
2020-08-04 10:08 ` Yoshiki Komachi
2020-07-31 17:48 ` Andrii Nakryiko
2020-08-04 10:35 ` Yoshiki Komachi
2020-07-31 21:52 ` [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup John Fastabend
2020-08-05 10:26 ` Yoshiki Komachi
2020-08-05 16:36 ` David Ahern
2020-08-07 8:30 ` Yoshiki Komachi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5970d82b-3bb9-c78f-c53a-8a1c95a1fad7@gmail.com \
--to=dsahern@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=komachi.yoshiki@gmail.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).