bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <ast@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 bpf-next 0/6] bpf: Introduce global functions
Date: Fri, 10 Jan 2020 17:29:50 +0100	[thread overview]
Message-ID: <5ba36dd3-f9f0-a7c3-e9cf-88bc7c1dce88@iogearbox.net> (raw)
In-Reply-To: <20200110064124.1760511-1-ast@kernel.org>

On 1/10/20 7:41 AM, Alexei Starovoitov wrote:
> v2->v3:
> - cleaned up a check spotted by Song.
> - rebased and dropped patch 2 that was trying to improve BTF based on ELF.
> - added one more unit test for scalar return value from global func.
> 
> v1->v2:
> - addressed review comments from Song, Andrii, Yonghong
> - fixed memory leak in error path
> - added modified ctx check
> - added more tests in patch 7
> 
> v1:
> Introduce static vs global functions and function by function verification.
> This is another step toward dynamic re-linking (or replacement) of global
> functions. See patch 2 for details.
> 
> Alexei Starovoitov (6):
>    libbpf: Sanitize global functions
>    bpf: Introduce function-by-function verification
>    selftests/bpf: Add fexit-to-skb test for global funcs
>    selftests/bpf: Add a test for a large global function
>    selftests/bpf: Modify a test to check global functions
>    selftests/bpf: Add unit tests for global functions
> 
>   include/linux/bpf.h                           |   7 +-
>   include/linux/bpf_verifier.h                  |  10 +-
>   include/uapi/linux/btf.h                      |   6 +
>   kernel/bpf/btf.c                              | 175 +++++++++---
>   kernel/bpf/verifier.c                         | 252 ++++++++++++++----
>   tools/include/uapi/linux/btf.h                |   6 +
>   tools/lib/bpf/libbpf.c                        |  35 ++-
>   .../bpf/prog_tests/bpf_verif_scale.c          |   2 +
>   .../selftests/bpf/prog_tests/fexit_bpf2bpf.c  |   1 +
>   .../bpf/prog_tests/test_global_funcs.c        |  82 ++++++
>   .../selftests/bpf/progs/fexit_bpf2bpf.c       |  15 ++
>   tools/testing/selftests/bpf/progs/pyperf.h    |   9 +-
>   .../selftests/bpf/progs/pyperf_global.c       |   5 +
>   .../selftests/bpf/progs/test_global_func1.c   |  45 ++++
>   .../selftests/bpf/progs/test_global_func2.c   |   4 +
>   .../selftests/bpf/progs/test_global_func3.c   |  65 +++++
>   .../selftests/bpf/progs/test_global_func4.c   |   4 +
>   .../selftests/bpf/progs/test_global_func5.c   |  31 +++
>   .../selftests/bpf/progs/test_global_func6.c   |  31 +++
>   .../selftests/bpf/progs/test_global_func7.c   |  18 ++
>   .../selftests/bpf/progs/test_pkt_access.c     |  28 ++
>   .../selftests/bpf/progs/test_xdp_noinline.c   |   4 +-
>   22 files changed, 746 insertions(+), 89 deletions(-)
>   create mode 100644 tools/testing/selftests/bpf/prog_tests/test_global_funcs.c
>   create mode 100644 tools/testing/selftests/bpf/progs/pyperf_global.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func1.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func2.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func3.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func4.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func5.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func6.c
>   create mode 100644 tools/testing/selftests/bpf/progs/test_global_func7.c
> 

Applied, thanks!

      parent reply	other threads:[~2020-01-10 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  6:41 [PATCH v3 bpf-next 0/6] bpf: Introduce global functions Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 1/6] libbpf: Sanitize " Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 2/6] bpf: Introduce function-by-function verification Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 3/6] selftests/bpf: Add fexit-to-skb test for global funcs Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 4/6] selftests/bpf: Add a test for a large global function Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 5/6] selftests/bpf: Modify a test to check global functions Alexei Starovoitov
2020-01-10  6:41 ` [PATCH v3 bpf-next 6/6] selftests/bpf: Add unit tests for " Alexei Starovoitov
2020-01-10 16:29 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ba36dd3-f9f0-a7c3-e9cf-88bc7c1dce88@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).