From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DDBC33CA7 for ; Sun, 12 Jan 2020 00:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B67072084D for ; Sun, 12 Jan 2020 00:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z/D8M+2k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731800AbgALAvb (ORCPT ); Sat, 11 Jan 2020 19:51:31 -0500 Received: from mail-io1-f53.google.com ([209.85.166.53]:38559 "EHLO mail-io1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731798AbgALAva (ORCPT ); Sat, 11 Jan 2020 19:51:30 -0500 Received: by mail-io1-f53.google.com with SMTP id c16so1580230iom.5; Sat, 11 Jan 2020 16:51:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=8+5Zi6EPQUI9C9YNOULqQb2kobiRYzXoui8nLxFWWJQ=; b=Z/D8M+2kjfGzAlkzdbnPzI3JSmwAGEjG4+vbW14cjLCoBUN2R0Sq574meZAKzcvMqg 96kggTmOxhmWJnnHdO0T+g9YKxLU/b3O0yA+zTeFqUDSIoynxZK11IGzWidSNLbvfWcd 9MpeX8sRdJReFmPSghVgYMiMDpTUiRif9oWPU8qEeHk4BNtWxOVkKM3EaMjXZH7M3sHC ZQgV8gjieVRHwcBoUt5e2KlYeDBfFhg01WlGaS5jlVZvhKO5H3kvrIv3aozGWn1Dv3L3 tKORGxpG+dCCK5A4eZzSiuBTTpRnzhYYdAMC8yzoAkWxzS633/vUWtga+ryJNdcgutH/ huGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=8+5Zi6EPQUI9C9YNOULqQb2kobiRYzXoui8nLxFWWJQ=; b=sP5R1do77S6g3LDUovoeJBVr8yYL2gwSlF9/6ApEVfhueObrhE0a75pPfR1aIg/Wxr Wm4VyadgrBjOdLOc1UsMIBMgBFODziEuiz+bCzpvGavYnuloLW2zhNKW63ecF3K/BCEB 4eNBkNzP4MU8g3ptJl8/7QANVHZIM90AGgL2BLUirkZIhN/E2tJ7UgplvL+oZ6J/qsNy GkWAvHrFQBzy2g7GjjO5Lb5okJZJAPNWJLijMRqhm3DA5XGoV6nzsRyuy+mGP4D2xKP3 cpAEIHq01SUrumbzWw0iJYOC6z7AjXRj6Vvsr3IwsH917UsJyYWGdMICw6YK7sVLAvnK mb5w== X-Gm-Message-State: APjAAAVz3HDr/1IHoyQqxfxqJqqIS6lCrwgLp/WXZ/LpBKUlGvWKr6AA Qy5BIox5Q6+VJ8H3rwyop+s= X-Google-Smtp-Source: APXvYqxy+BTqRhJQ1dkGmzUWdAchQyRVVTHowMb2yempFncwFMLdBOKAwWEmr7gbbYmvpgGsfGu8BA== X-Received: by 2002:a5e:941a:: with SMTP id q26mr7847425ioj.135.1578790290109; Sat, 11 Jan 2020 16:51:30 -0800 (PST) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id j69sm2237249ilg.67.2020.01.11.16.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2020 16:51:28 -0800 (PST) Date: Sat, 11 Jan 2020 16:51:22 -0800 From: John Fastabend To: Jakub Sitnicki , bpf@vger.kernel.org Cc: netdev@vger.kernel.org, kernel-team@cloudflare.com, Eric Dumazet , John Fastabend , Lorenz Bauer , Martin KaFai Lau Message-ID: <5e1a6d8a5de6c_1e7f2b0c859c45c063@john-XPS-13-9370.notmuch> In-Reply-To: <20200110105027.257877-7-jakub@cloudflare.com> References: <20200110105027.257877-1-jakub@cloudflare.com> <20200110105027.257877-7-jakub@cloudflare.com> Subject: RE: [PATCH bpf-next v2 06/11] bpf, sockmap: Don't set up sockmap progs for listening sockets Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Jakub Sitnicki wrote: > Now that sockmap can hold listening sockets, when setting up the psock we > will (i) grab references to verdict/parser progs, and (2) override socket > upcalls sk_data_ready and sk_write_space. > > We cannot redirect to listening sockets so we don't need to link the socket > to the BPF progs, but more importantly we don't want the listening socket > to have overridden upcalls because they would get inherited by child > sockets cloned from it. > > Introduce a separate initialization path for listening sockets that does > not change the upcalls and ignores the BPF progs. > > Signed-off-by: Jakub Sitnicki > --- > net/core/sock_map.c | 34 +++++++++++++++++++++++++++++++++- > 1 file changed, 33 insertions(+), 1 deletion(-) Any reason only support for sock_map types are added? We can also support sock_hash I presume? Could be a follow up patch I guess but if its not too much trouble would be worth adding now vs trying to detect at run time later. I think it should be as simple as using similar logic as below in sock_hash_update_common Thanks.