From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506D7C10DCE for ; Fri, 6 Mar 2020 15:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 269F82084E for ; Fri, 6 Mar 2020 15:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4vpLS/A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgCFPAV (ORCPT ); Fri, 6 Mar 2020 10:00:21 -0500 Received: from mail-pg1-f176.google.com ([209.85.215.176]:33743 "EHLO mail-pg1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbgCFPAV (ORCPT ); Fri, 6 Mar 2020 10:00:21 -0500 Received: by mail-pg1-f176.google.com with SMTP id m5so1213756pgg.0; Fri, 06 Mar 2020 07:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=MKEmgwlqImsxarOX2o7kC0mazgsEGwxs8c0oeOuM3CM=; b=B4vpLS/AUvQrd88ytL5Wvq2bco/f6qnYtm0MQiielcC4LzZ85jVsab+E14oCofZ3MH 7mPxuNbntryzhL2l22hhupQ+fDhrM+mC4s9zRyiULGqYBFnlzMN5St1z5PsyhD4nhFT2 /D3k3H71VHU9956jrxPZOLKLUjtFEm5DhaZ7E98ISW+nMERBx3qgl/sfTfq1abrVsNc0 UgYHMMlRZwTnUbtMDp/Oyon4ULlUGxCHwtzDblx2hjbcIepA6uYBX0WGMgtBaPRFkPN4 QzXp7/iWC7gbI5QoFDOOL13kkzFvQG1cDQu2YQfXyXEWoMkpLWg7XXEgthI/ySGbJ5Bo ma5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=MKEmgwlqImsxarOX2o7kC0mazgsEGwxs8c0oeOuM3CM=; b=JllNqIhpBwTOye6eVOBXj5sqb/xycBnSA1JYO6aBHu2JrNLSKxYnfGiCxiE3+4SMvU Z80ZdwmzC7WvcAqIAF08x99SVKFPSLhjFQqyJn7yMtRxm+QMO92qFpwhR8sSfRTvz+97 zx521YB9dUnThyaHiZIcYor12XJkmb4sO6oFZSpoHxPz8TLXVUrHanc56Mp0DwDjJd64 0eST7fORPWJWaawsnSeQPLPF0XLDT4jUUv1lpDgPmUpNwP+6DA87lkBONpVOSGe5bON+ EkYVkJtPQ1Nz5++r7uUgJdXumWndMNyue6RJ06IaslWXZ/C5Kl0Hs0N+N5YwIeigbRT4 P9lg== X-Gm-Message-State: ANhLgQ33CvizxrPn/WjwkhbksDEqXmSxH74px73SntvXjTB2wfNlxZ1z OZOTUkpMaD54vxrTBAgfcLM= X-Google-Smtp-Source: ADFU+vviqkVpH4QiwaiJdmQ+yhFp9Oxc07sYl5jRDmd+qhfObFfVUpP/+vlqlx9bBes/OmEmcvj1tA== X-Received: by 2002:a63:a062:: with SMTP id u34mr3850216pgn.286.1583506820741; Fri, 06 Mar 2020 07:00:20 -0800 (PST) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id y23sm17165459pfb.76.2020.03.06.07.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 07:00:19 -0800 (PST) Date: Fri, 06 Mar 2020 07:00:11 -0800 From: John Fastabend To: Lorenz Bauer , john.fastabend@gmail.com, Daniel Borkmann , Jakub Sitnicki , Lorenz Bauer , Eric Dumazet , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski , Alexei Starovoitov Cc: kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5e62657bb6fe8_17502acca07205b4b2@john-XPS-13-9370.notmuch> In-Reply-To: <20200304101318.5225-3-lmb@cloudflare.com> References: <20200304101318.5225-1-lmb@cloudflare.com> <20200304101318.5225-3-lmb@cloudflare.com> Subject: RE: [PATCH bpf-next v3 02/12] skmsg: update saved hooks only once Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Lorenz Bauer wrote: > Only update psock->saved_* if psock->sk_proto has not been initialized > yet. This allows us to get rid of tcp_bpf_reinit_sk_prot. > > Signed-off-by: Lorenz Bauer > --- Nice bit of cleanup thanks. Acked-by: John Fastabend