bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: RE: [PATCH bpf-next 1/2] samples: bpf: move read_trace_pipe to trace_helpers
Date: Tue, 10 Mar 2020 14:11:40 -0700	[thread overview]
Message-ID: <5e68028c1257a_586d2b10f16785b86f@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20200310055147.26678-2-danieltimlee@gmail.com>

Daniel T. Lee wrote:
> To reduce the reliance of trace samples (trace*_user) on bpf_load,
> move read_trace_pipe to trace_helpers. By moving this bpf_loader helper
> elsewhere, trace functions can be easily migrated to libbbpf.
> 
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
> ---
>  samples/bpf/Makefile                        |  4 ++--
>  samples/bpf/bpf_load.c                      | 20 ------------------
>  samples/bpf/bpf_load.h                      |  1 -
>  samples/bpf/tracex1_user.c                  |  1 +
>  samples/bpf/tracex5_user.c                  |  1 +
>  tools/testing/selftests/bpf/trace_helpers.c | 23 +++++++++++++++++++++
>  tools/testing/selftests/bpf/trace_helpers.h |  1 +
>  7 files changed, 28 insertions(+), 23 deletions(-)
> 

Acked-by: John Fastabend <john.fastabend@gmail.com>

  reply	other threads:[~2020-03-10 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  5:51 [PATCH bpf-next 0/2] samples: bpf: refactor perf_event user program with libbpf bpf_link Daniel T. Lee
2020-03-10  5:51 ` [PATCH bpf-next 1/2] samples: bpf: move read_trace_pipe to trace_helpers Daniel T. Lee
2020-03-10 21:11   ` John Fastabend [this message]
2020-03-10  5:51 ` [PATCH bpf-next 2/2] samples: bpf: refactor perf_event user program with libbpf bpf_link Daniel T. Lee
2020-03-10 21:33   ` John Fastabend
2020-03-10 22:49     ` Daniel T. Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e68028c1257a_586d2b10f16785b86f@john-XPS-13-9370.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=danieltimlee@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).