From: John Fastabend <john.fastabend@gmail.com>
To: Song Liu <songliubraving@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: quentin@isovalent.com, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, arnaldo.melo@gmail.com, jolsa@kernel.org,
Song Liu <songliubraving@fb.com>
Subject: RE: [PATCH bpf-next 0/2] Fixes for bpftool-prog-profile
Date: Tue, 10 Mar 2020 15:00:37 -0700 [thread overview]
Message-ID: <5e680e05a8667_74702b1610cf25b4b4@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20200310183624.441788-1-songliubraving@fb.com>
Song Liu wrote:
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf.
>
> Song Liu (2):
> bpftool: only build bpftool-prog-profile with clang >= v11
> bpftool: skeleton should depend on libbpf
>
> tools/bpf/bpftool/Makefile | 15 ++++++++++++---
> tools/bpf/bpftool/prog.c | 2 ++
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> --
> 2.17.1
Maybe instead of "Please recompile" -> "Please build" sounds a bit better
to me but that is probably a matter of preference and doesn't matter much.
Anyways for the series,
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2020-03-10 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 18:36 [PATCH bpf-next 0/2] Fixes for bpftool-prog-profile Song Liu
2020-03-10 18:36 ` [PATCH bpf-next 1/2] bpftool: only build bpftool-prog-profile with clang >= v11 Song Liu
2020-03-10 22:44 ` Quentin Monnet
2020-03-10 22:54 ` Alexei Starovoitov
2020-03-10 18:36 ` [PATCH bpf-next 2/2] bpftool: skeleton should depend on libbpf Song Liu
2020-03-10 22:00 ` John Fastabend [this message]
2020-03-11 4:33 ` [PATCH bpf-next 0/2] Fixes for bpftool-prog-profile Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e680e05a8667_74702b1610cf25b4b4@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).